From: Greg KH <gregkh@linuxfoundation.org>
To: Harinath Nampally <harinath922@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c
Date: Mon, 8 May 2017 06:32:28 +0200 [thread overview]
Message-ID: <20170508043228.GA1553@kroah.com> (raw)
In-Reply-To: <1494216977-26852-1-git-send-email-harinath922@gmail.com>
On Mon, May 08, 2017 at 12:16:17AM -0400, Harinath Nampally wrote:
> All below warnings are found and fixed by checkpatch.pl:
> CHECK: struct mutex definition without comment
> CHECK: Alignment should match open parenthesis
> WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred.
You should only don "one thing" per patch, and no, "fix coding style
issues" is not "one thing" :)
Please break this up into multiple patches and send it as a patch
series.
thanks,
greg k-h
next prev parent reply other threads:[~2017-05-08 4:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 4:16 [PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c Harinath Nampally
2017-05-08 4:32 ` Greg KH [this message]
[not found] ` <CAAGUq_pQy5xnLgTW3D6eikR0O+Bh_iOh+fdvtFL=8GTssXXEtw@mail.gmail.com>
2017-05-08 5:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508043228.GA1553@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=harinath922@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox