From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751784AbdEHEck (ORCPT ); Mon, 8 May 2017 00:32:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42468 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbdEHEcj (ORCPT ); Mon, 8 May 2017 00:32:39 -0400 Date: Mon, 8 May 2017 06:32:28 +0200 From: Greg KH To: Harinath Nampally Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c Message-ID: <20170508043228.GA1553@kroah.com> References: <1494216977-26852-1-git-send-email-harinath922@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494216977-26852-1-git-send-email-harinath922@gmail.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 08, 2017 at 12:16:17AM -0400, Harinath Nampally wrote: > All below warnings are found and fixed by checkpatch.pl: > CHECK: struct mutex definition without comment > CHECK: Alignment should match open parenthesis > WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. You should only don "one thing" per patch, and no, "fix coding style issues" is not "one thing" :) Please break this up into multiple patches and send it as a patch series. thanks, greg k-h