From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407AbdEHF7Y (ORCPT ); Mon, 8 May 2017 01:59:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44616 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbdEHF7X (ORCPT ); Mon, 8 May 2017 01:59:23 -0400 Date: Mon, 8 May 2017 07:59:13 +0200 From: Greg KH To: Surender Polsani Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [V4] staging : rtl8188eu : remove void function return Message-ID: <20170508055913.GA18310@kroah.com> References: <1494222755-25850-1-git-send-email-surenderpolsani@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494222755-25850-1-git-send-email-surenderpolsani@gmail.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 08, 2017 at 11:22:35AM +0530, Surender Polsani wrote: > kernel coding style doesn't allow the return statement > in void function. > > Signed-off-by: Surender Polsani > --- > Changes for v2: > corrected subject line as suggested > Changes for v3: > modified from line as suggested by Greg KH > placed a semicolon in label for fixing build error > Changes for v4: > changes made as suggested by Dan Carpenter > --- > drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > index d04b7fb..bf9f10f 100644 > --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > @@ -146,7 +146,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) > > if (!hw_init_completed) > goto skip_dm; > - Why did you remove this line? > /* ODM */ > pmlmepriv = &Adapter->mlmepriv; > > @@ -165,7 +164,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) > skip_dm: > /* Check GPIO to determine current RF on/off and Pbc status. */ > /* Check Hardware Radio ON/OFF or not */ > - return; > + ; Why is the ';' still here? You do understand the C language, right? thanks, greg k-h