From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755329AbdEHPQI (ORCPT ); Mon, 8 May 2017 11:16:08 -0400 Received: from mail-co1nam03on0044.outbound.protection.outlook.com ([104.47.40.44]:32782 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754771AbdEHPQD (ORCPT ); Mon, 8 May 2017 11:16:03 -0400 Authentication-Results: cavium.com; dkim=none (message not signed) header.d=none;cavium.com; dmarc=none action=none header.from=cavium.com; Date: Mon, 8 May 2017 20:45:36 +0530 From: Linu Cherian To: Robert Richter Cc: Geetha sowjanya , will.deacon@arm.com, robin.murphy@arm.com, lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, iommu@lists.linux-foundation.org, jcm@redhat.com, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, geethasowjanya.akula@gmail.com, Charles.Garcia-Tobin@arm.com Subject: Re: [PATCH v3 0/7] Cavium ThunderX2 SMMUv3 errata workarounds Message-ID: <20170508151536.GA27789@virtx40> References: <1493986091-30521-1-git-send-email-gakula@caviumnetworks.com> <20170505222250.GY16981@rric.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170505222250.GY16981@rric.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR01CA0089.INDPRD01.PROD.OUTLOOK.COM (10.174.56.29) To CO2PR07MB2517.namprd07.prod.outlook.com (10.166.200.151) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 66bcd6a0-538b-4213-de69-08d496252260 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CO2PR07MB2517; X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2517;3:q7NV5s5mQb0XqXC+X+WjsO4rZsFWsq2YVXJYA/RqsTchZ6FtuxjOqhSlmHegWO7dw0uPUVnzpXupUgjjVCJ5keTEesrHOLky1J2mBYEDCkcncH8/ll9dGnnyBEy5MCesgDp2MG6Ix9dt+Uvowx2CNG4010fZ7B79xkeCJPXYD62gyrkMZqAVwUhTDbjJl0jpKKZXcIu2AugMh+fpCIWpxnNf49Mrc8SKqus2RCTwhBuyvnutndhw9MqCuFmXUgCx3T65miZVBKOmRjP807aNRsOPKc+6yO1Wjx9zGxbkjte/bq+XSGFtFX57GAhPwPkMwZHm1G57qSqsURzwd0z8Tw==;25:cvpwUtDOkYrcuGQkN4VpCwNeLwvBKB/PttJvimogar+5cpGJKqu1X9GbZP5Ugr4WeCFEnmo+UiEF/y6wQm6ypWO1A0WuNNInZotq/Y1YObcbb6BWR3aLTZvdb9mQaIGyW6Sy1CFBOsu18gIp3syJpdeOFWLFZncBkVvZh/F1DiZ3yqlJthoEPZWV92+zGPhljrxUQS8nabEuXjbmq49QX8Ph6ZdphXusWgugoS4S7zmEYWY8FhXssJ7cwpubUvTUsdyLpONOkspuDKcdl9k2quqhQWWDmzTQJUt8EE1Kyfm89Yry65O1Z1Q36XdOZYYoDVQ6dz+mYQecLYmrf27LVcUkLGTU6jykdY4o+ZTl1qTggYEi3Yo1i/eu4OJyhIcDAzgW/FMmu7S8DobbhOq8kYT/Ye0VZRQX5L2EG48HKdkc0VBWTDLN0GK5bgAXQyld38E89i9jsLbvqBqKOd3Gb98MPckZMv9ALi1E67nxxZk= X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2517;31:Qv/roGOnQ65huCF9C5e+xzISUrUs4xy1Dtw7YjHN64dhW0X1vX0Lstamfour/khfSVmggRkH2R7LbwXMwXlkb//8+VhoNHKamhhNrW3P2JYNjghI8VYYjJGsItsBpprnZONgxB4JGmuak2/jk4tg/SOMCcfyNovrUPINvNUF1eOZZz3PwyENo95inhqr6lXgqUHE7EgyYPqZ1MbK3wCmILcbolLvdrXEIJ6+YTu7l0Q=;20:eYIiG7tU3e40YO44eALnktR4nQ32rvVhHMmIK0xbDOpzaA+C2qHoSLymRP1p0LUkIzodHRMKw/teXv2RF06mZSM0pcE6CP9H2TeZ1VmWuSDkr5lnP2b5fGQ0IJfrTvcJBKYZazEscn/VRx/8sDh1M+apsQfPHyeGcLt1BcBM3JzpOm/CNHIXWxrH9jEnA+fdvayqCkB7UtN4iye5GZbZgRDujb2nNtHFk8mFBy5UWapafk8+OJ54LUoL21o4pl5/Oefqmnp//hey91RhbpzIpKME8JxGKBYnL6c7bnXD6lyiMMZQ6/yJRb2bJ1m6mcqoQFj/9gDT/TR3Z97nOzGqzeJ2yTTGccHxN2VoxI1cD9vY6fwQjZFkWT7nn9I2C8T72D2USTge39cLw3wGt2Ud3YBHjN5P1GeUHRTWe1y5qdmYldGusHEFTjE1wDBobZiRH/nCO0w1jEylQOcEsyw1qDlMYQ0YtMpt1gu+l6Sw3jbjm6dBy6Ck7AfCPF5qz3m0 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123562025)(20161123560025)(20161123555025)(6072148);SRVR:CO2PR07MB2517;BCL:0;PCL:0;RULEID:;SRVR:CO2PR07MB2517; X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2517;4:TfyDpuigtlkvKSaBIdeCUzkqZR6TFhAu/lnJOEkEb6nB/KX922DvqFuK3U8uMCmba6faexuo6XYo5OGkNZRXPJMihVR36kSXhuU4i1OkQFUK0o4RJDT15rJUtV4NBRaJ/nIQ2jflbLX2hZPJ43ROgpLRWJPCOP587lSjiNQ2YGfs1PmhOWv4LaOkWjPG9r9K1eRLQ4G3S74i8KdA+BaZYHBnODkG06K3wZKSvbBrXNhIkob6F8MNWDxVKbiCrSlwj97ZPShtzBN6R6MEbHFSYWaVsktMW5CG7qCjbpbczCXkjTH+q/EWowpuAHLHGCkv2weDa6ddYrVSU83KGSj7WJHSJUEybHsfmox3hlv57+1gmtychF8D68gybPyBh9YhTvK2MnI5pBafW9Bsrp3b9RDZZ5GgjyN9k1bg/f+tdlAVHpsfn/KQ1z+l6rK+oLijDkbfC31OOWElxvj40VEAGy/5oq6JLZqZ2hl75yGI2M8j/zzk9g31HrJu5fDo7y6hyHPOZj2YF6b4c0Zsk4phctywoPqword6pClzEzdIgOlJHmR/6A72uFvM4wrgIT3EcwsJog57GqHXaByWQAkqwBZNssAsJAdk8O5bSs87bXV7+2sZWKzKNfKaj1Mj9InxGG4e0RS2A2w12S24GCUU+YPj3V0Guuw/9PYH0coz9nCHOsQ/36kYESE7QJnynehyJXu1DRwC+5w9gfIemqNMBk/Xqe1TzhPfe3Y3fjCFWiQ5aDLK9lh9kgKI1h85fszCgR/nwGuJw12O0uFjb3bHouAbue7n+WS8qHUHJ+ODpqY= X-Forefront-PRVS: 0301360BF5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(39450400003)(39840400002)(39850400002)(39400400002)(39410400002)(24454002)(47776003)(2950100002)(7736002)(122856001)(23726003)(54356999)(50986999)(76176999)(33716001)(66066001)(305945005)(53546009)(6862004)(4326008)(478600001)(6116002)(3846002)(7416002)(42186005)(5660300001)(1076002)(6246003)(110136004)(4001350100001)(38730400002)(6636002)(53936002)(50466002)(6306002)(9686003)(8676002)(81166006)(229853002)(2906002)(189998001)(33656002)(83506001)(86362001)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR07MB2517;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO2PR07MB2517;23:dXaX/8u+Uvbz0xpS/gPDoVd9Y1IyLzVQJUY0X1I4F?= =?us-ascii?Q?A4xI1i2WBuI+iqMdnbFtpsxMevRwZ/t5w3orrQimSA3wqYikne0i5sqY+DlY?= =?us-ascii?Q?+p7aruEoCB/fDVZ1+NlvzSGQLfyO+QvG8oYZfuQXMftY1Wwiwm3dTIAWrzzP?= =?us-ascii?Q?waqeHCGQ8hjdSY4jYdQBVjGagpKVz3voo9DGYm7HrUigP47DahOMBgooZBn/?= =?us-ascii?Q?O2Bl3m70qmzMI0g0x9DQ2d6qRg3DbWm+f6pgT5FwriuzKrIVBpWZhMeHJFFP?= =?us-ascii?Q?C/uG34VVkSFVq4fju4YVIL0ydo8mMtMFYJI47aiS2V2RKRqOf64Gk2YJUKJE?= =?us-ascii?Q?s/rjMCujzO1IPVVfGZUEEWg834aEajUbr2Q6DGmCn22NpJhs8R0WnSlIb3Kr?= =?us-ascii?Q?femBJZlWjf8kVRKt+y7b9EJ6Z9Aqa5p8QmgeV3SxYU2pqcekI2a2lxMSJeMj?= =?us-ascii?Q?gO0wkDKKTYgE43koz1gP8TIl9rGijrH88DgoTE0rLycIxzX7gAdcWxBUDNG+?= =?us-ascii?Q?Is7OGd+qv74xvu37YrCDwCJo6CN2m7gtm66QFbvjXAZgpGgVw5uwjYItozsR?= =?us-ascii?Q?mHCyQXJDIaWoddvvySUqZGD4CAak4U6UiQwZcsBkhMKamXh4Q0OfoXYCv9jl?= =?us-ascii?Q?0tuFbMHU5b/P7051R+E/Ds24TBNZ7zPK0iYuAovpl5fuvT9eP+IRrN3B3rBg?= =?us-ascii?Q?Rrvls6pK2fxwHtqhDXc9E74A6Q5/9oNbcWU0I6YhWBRqqnEv0p1ugaBmHc0Y?= =?us-ascii?Q?ziEfLl2a/3NB1y1UeQCz80lL/rBVwzW+Q7iSJzObXAr3F3mCKnYuKcDzN+wX?= =?us-ascii?Q?Yl9Ogs5UyyzczdhgdNgWfCQHWPqDlIJR94Qmj9c/DK9Ulx8ufnh1UoF4oI6v?= =?us-ascii?Q?HVXLCBrIXpK1VDvxkVY+Na45jW0LyfdBza7mlTCjK1REnyzfUuvrnTzkBBQh?= =?us-ascii?Q?rN98681cSeNDOkFV+jLGqZzy/LBgLIb+vJMqUEbGx1ob3IzP5TPHYWDl++9u?= =?us-ascii?Q?dxNIylvMo4/Zkr3/0MnGEFN4qkyhQawRLKDOIiTcbINofQl5xW0/ujXINOg7?= =?us-ascii?Q?nxY+qQf1Ro2C0imKktijkZv7FPP80fypyoZqxr7SndWbf45lNUW4pIFcQM+l?= =?us-ascii?Q?J7W/2rRSFpBFA///WW24VhOoZ93CUlzvoWuaOIxdMQqELH52zOBqEI4imibv?= =?us-ascii?Q?iEAKijpqxQ0tdxn7j44Ig1JB2dZ8/O7irFt?= X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2517;6:RuBOHsv3MjT7pW9QwGLxNsqkPnCwnqgZi4J5WqPN5XfZGaV865EaheD6l1zYVEAOdJ7T6f//0vlecTh38CYI2J6BzUQ73Se6t59Dk+i8p5hMyQj4MJJcML3bEwYM6DItICctFKlreb3w/YMUYgRrxpFAWyagn8E5LQxWAY75d6WsiUvgbWy0DNMSjWgOCLt5KWYpQ8UkhxlNsU6zf5gCvpKNUCeumxtsagLOtEeLLvHm+sj2Ld/yDKUn9lQJYt8X51RyHB1FM3XM5T+a4oD+MwsDagaZED/ft+kFtOL5Qhr8VIfJqyAeq/4UPQ5vGfNl6+G3R/ipoJr1DYB6XklxZi2mW+8Na/9yYOtboOwKh5cts3FAx/7Nj4tWBZSvgaJ9PFCiD3xin8CsNrV+AzGQndb2+okueUWOprdCi4T5hAGIu0+53p5GZf+c5zsKKyHCsN3oZDUZovHRm2vCgsrVXHk+Va1UR1cVGl5HY/k3pWKHS0H9uYZrt/auCM4aiypUVjBk740fZaMjnNpkt/pyTw==;5:vvP6fkFS02p3h9rWAP5voc7M42usEUL8k2qc3Ne9iv3v3gqjapr+dqOyrMEL2g0t1taXCbEtywoqFh5zLQx/n8+EUZpQa4HvteTuYA95nPVqJ6CbAumDsZWzqJ23VPxZegl/rbJEJRBBTP9G08VvSA==;24:bIh+4Hcr1/8UrB5QDJyM+mYfDlcAFv4/X54ryk4ZFf0PQg0Bl4oeEkdlcmLMxK0c4jXcs3cOAojhGtet2ULv4gJ9HyY2BdrJzhKLVeV9CCI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2517;7:rJH4dmHqomt6U3/+QIsmfxMn6E7zvHPYTaejU/bJeobMVEnRmdUmgfL47ffVhU1i8BkRC0vF0qyDvAfD8F1H2kv17JlivsdowkPq85KanSZgNluoYE3oklTueJdT0o2Bbu5l8qGLYk0nIKFkDpx7oZp01IRoZ9786YiZKfDV4Iheinrp0mopJvIFj0j5XHKDyGHPc5ETdBcP1FBiK51egK1f2Pu7wvop6j8AHe3RO1i94Q+xj5+AMgj/Meom9hvRcbgqqLxE/k/BCTIMvk5VT71AklylIbHkNXwGQlon/zAAtgJ0AZSowf4ksjnhINnAZXZzDCRrSR+yx1ByYfod3w== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2017 15:15:56.1980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2517 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat May 06, 2017 at 12:22:50AM +0200, Robert Richter wrote: > On 05.05.17 17:38:04, Geetha sowjanya wrote: > > From: Linu Cherian > > > > Cavium ThunderX2 SMMUv3 implementation has two Silicon Erratas. > > 1. Errata ID #74 > > SMMU register alias Page 1 is not implemented > > 2. Errata ID #126 > > SMMU doesnt support unique IRQ lines and also MSI for gerror, > > eventq and cmdq-sync > > > > The following patchset does software workaround for these two erratas. > > > > This series is based on patchset. > > https://www.spinics.net/lists/arm-kernel/msg578443.html > > > > Changes from v1: > > Since the use of MIDR register is rejected and SMMU_IIDR is broken on this > > silicon, as suggested by Will Deacon modified the patches to use ThunderX2 > > SMMUv3 IORT model number to enable errata workaround. > > > > Changes from v2: > > Updated "Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt" document with > > new SMMU option used to enable errata workaround. > > > > Geetha Sowjanya (1): > > iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #126 > > > > Linu Cherian (6): > > iommu/arm-smmu-v3: Introduce smmu option PAGE0_REGS_ONLY for ThunderX2 > > errata#74. > > iommu/arm-smmu-v3: Do resource size checks based on SMMU option > > PAGE0_REGS_ONLY > > ACPICA: IORT: Add Cavium ThunderX2 SMMUv3 model definition. > > iommu/arm-smmu-v3: For ACPI based device probing, set PAGE0_REGS_ONLY > > option for ThunderX2 SMMUv3 implementations. > > ACPI/IORT: Fixup SMMUv3 resource size for Cavium ThunderX2 SMMUv3 > > model > > arm64: Documentation: Add Cavium ThunderX2 SMMUv3 erratas > > This split into patches does not look reasonable to me. 1 patch only > for each workaround should be sufficient. > * Should we not atleast keep the changes in drivers/acpi/iort.c and include/acpi/actbl2.h seperate, since they are outside smmuv3 driver ? * Probably i can merge the below patches, 1. iommu/arm-smmu-v3: Introduce smmu option PAGE0_REGS_ONLY for ThunderX2 errata#74. 2. iommu/arm-smmu-v3: Do resource size checks based on SMMU option PAGE0_REGS_O Is that fine ? Thanks. -- Linu cherian