From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754513AbdEHQ6k (ORCPT ); Mon, 8 May 2017 12:58:40 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46005 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998AbdEHQ6i (ORCPT ); Mon, 8 May 2017 12:58:38 -0400 Date: Mon, 8 May 2017 18:58:27 +0200 From: Peter Senna Tschudin To: Lucas Stach Cc: Kishon Vijay Abraham I , Bjorn Helgaas , Jingoo Han , Richard Zhu , Murali Karicheri , Minghuan Lian , Mingkai Hu , Roy Zang , Thomas Petazzoni , Niklas Cassel , Jesper Nilsson , Joao Pinto , Zhou Wang , Gabriele Paoloni , Stanimir Varbanov , Pratyush Anand , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures Message-ID: <20170508165827.GC12665@collabora.com> References: <20170508150224.GA7458@collabora.com> <1494261248.2322.21.camel@pengutronix.de> <20170508164440.GB12665@collabora.com> <1494262128.2322.22.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494262128.2322.22.camel@pengutronix.de> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 08, 2017 at 06:48:48PM +0200, Lucas Stach wrote: > Am Montag, den 08.05.2017, 18:44 +0200 schrieb Peter Senna Tschudin: > > On Mon, May 08, 2017 at 06:34:08PM +0200, Lucas Stach wrote: > > > Am Montag, den 08.05.2017, 17:02 +0200 schrieb Peter Senna Tschudin: > > > > Hello Kishon, > > > > > > > > Our iMX6 hardware (imx6q-b850v3.dts) is not booting with latest > > > > linux-next and I could bisect until: > > > > > > > > commit 442ec4c04d1235f8c664a74004dae54a7a574d18 > > > > Author: Kishon Vijay Abraham I > > > > Date: Wed Feb 15 18:48:14 2017 +0530 > > > > > > > > PCI: dwc: all: Split struct pcie_port into host-only and core structures > > > > > > > > Which seem to be causing our issues. Our device (imx6q-b850v3.dts) boots > > > > fine with 4.10, and also boots if we disable pcie with: > > > > > > Are you sure about this bisect? It seems more likely that the secondary > > > bus scanning goes wrong. It seems Lorenzo Pieralisi's cfg space > > > non-posting patches landed in next, so the root cause of this might just > > > be the driver hooking the wrong fault code now. > > > > > > Async and synchronous aborts are different fault codes on ARM. Can you > > > see of removing the "16 +" in hook_fault_code() in > > > drivers/pci/dwc/pci-imx6.c fixes this issue? > > > > changing it to: > > > > hook_fault_code(6, imx6q_pcie_abort_handler, SIGBUS, 0, > > "imprecise external abort"); > > > > made no difference, problem persists... > > Can you test if 8 or 10 works? Also fails with 8 and with 10... > > Regards, > Lucas > >