From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754901AbdEHRIn (ORCPT ); Mon, 8 May 2017 13:08:43 -0400 Received: from mga03.intel.com ([134.134.136.65]:11159 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682AbdEHRIk (ORCPT ); Mon, 8 May 2017 13:08:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,310,1491289200"; d="scan'208";a="965890618" Date: Mon, 8 May 2017 11:08:36 -0600 From: Ross Zwisler To: Jan Kara Cc: Ross Zwisler , Andrew Morton , linux-kernel@vger.kernel.org, Alexander Viro , Alexey Kuznetsov , Andrey Ryabinin , Anna Schumaker , Christoph Hellwig , Dan Williams , "Darrick J. Wong" , Eric Van Hensbergen , Jens Axboe , Johannes Weiner , Konrad Rzeszutek Wilk , Latchesar Ionkov , linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-nvdimm@ml01.01.org, Matthew Wilcox , Ron Minnich , samba-technical@lists.samba.org, Steve French , Trond Myklebust , v9fs-developer@lists.sourceforge.net Subject: Re: [PATCH v2 1/2] dax: prevent invalidation of mapped DAX entries Message-ID: <20170508170836.GA19867@linux.intel.com> Mail-Followup-To: Ross Zwisler , Jan Kara , Andrew Morton , linux-kernel@vger.kernel.org, Alexander Viro , Alexey Kuznetsov , Andrey Ryabinin , Anna Schumaker , Christoph Hellwig , Dan Williams , "Darrick J. Wong" , Eric Van Hensbergen , Jens Axboe , Johannes Weiner , Konrad Rzeszutek Wilk , Latchesar Ionkov , linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-nvdimm@lists.01.org, Matthew Wilcox , Ron Minnich , samba-technical@lists.samba.org, Steve French , Trond Myklebust , v9fs-developer@lists.sourceforge.net References: <20170504195910.11579-1-ross.zwisler@linux.intel.com> <20170505072912.GA25424@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170505072912.GA25424@quack2.suse.cz> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2017 at 09:29:12AM +0200, Jan Kara wrote: > On Thu 04-05-17 13:59:09, Ross Zwisler wrote: > > dax_invalidate_mapping_entry() currently removes DAX exceptional entries > > only if they are clean and unlocked. This is done via: > > > > invalidate_mapping_pages() > > invalidate_exceptional_entry() > > dax_invalidate_mapping_entry() > > > > However, for page cache pages removed in invalidate_mapping_pages() there > > is an additional criteria which is that the page must not be mapped. This > > is noted in the comments above invalidate_mapping_pages() and is checked in > > invalidate_inode_page(). > > > > For DAX entries this means that we can can end up in a situation where a > > DAX exceptional entry, either a huge zero page or a regular DAX entry, > > could end up mapped but without an associated radix tree entry. This is > > inconsistent with the rest of the DAX code and with what happens in the > > page cache case. > > > > We aren't able to unmap the DAX exceptional entry because according to its > > comments invalidate_mapping_pages() isn't allowed to block, and > > unmap_mapping_range() takes a write lock on the mapping->i_mmap_rwsem. > > > > We could potentially do an rmap walk to see if each of the entries actually > > has any active mappings before we remove it, but this might end up being > > very expensive and doesn't currently look to be worth it. > > > > So, just remove dax_invalidate_mapping_entry() and leave the DAX entries in > > the radix tree. > > > > Signed-off-by: Ross Zwisler > > Fixes: c6dcf52c23d2 ("mm: Invalidate DAX radix tree entries only if appropriate") > > Reported-by: Jan Kara > > Reviewed-by: Jan Kara > > Cc: [4.10+] > > Ah, I've just sent out a series which contains these two patches and > another two patches which change the entry locking to fix the last spotted > race... So either just take my last two patches on top of these two or > take my series as a whole. Sounds good. You added a better comment in invalidate_inode_pages2_range(), so let's just use your version of this series.