From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752048AbdEHVzz (ORCPT ); Mon, 8 May 2017 17:55:55 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:34615 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751850AbdEHVzy (ORCPT ); Mon, 8 May 2017 17:55:54 -0400 Date: Mon, 8 May 2017 14:55:42 -0700 From: Kees Cook To: linux-kernel@vger.kernel.org Cc: Mark Fasheh , Joel Becker , ocfs2-devel@oss.oracle.com Subject: [PATCH] ocfs2: Use ERR_CAST() to avoid cross-structure cast Message-ID: <20170508215542.GA13401@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When trying to propegate an error result, the error return path attempts to retain the error, but does this with an open cast across very different types, which the upcoming structure layout randomization plugin flags as being potentially dangerous in the face of randomization. This is a false positive, but what this code actually wants to do is use ERR_CAST() to retain the error value. Signed-off-by: Kees Cook --- fs/ocfs2/export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/export.c b/fs/ocfs2/export.c index 827fc9809bc2..9f88188060db 100644 --- a/fs/ocfs2/export.c +++ b/fs/ocfs2/export.c @@ -119,7 +119,7 @@ static struct dentry *ocfs2_get_dentry(struct super_block *sb, if (IS_ERR(inode)) { mlog_errno(PTR_ERR(inode)); - result = (void *)inode; + result = ERR_CAST(inode); goto bail; } -- 2.7.4 -- Kees Cook Pixel Security