From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754179AbdEIFuT (ORCPT ); Tue, 9 May 2017 01:50:19 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:33189 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393AbdEIFuQ (ORCPT ); Tue, 9 May 2017 01:50:16 -0400 Date: Mon, 8 May 2017 22:50:12 -0700 From: Stephen Hemminger To: SF Markus Elfring Cc: Lino Sanfilippo , netdev@vger.kernel.org, Mirko Lindner , LKML , kernel-janitors@vger.kernel.org Subject: Re: sky2: Use seq_putc() in sky2_debug_show() Message-ID: <20170508225012.508f24c0@xeon-e3> In-Reply-To: References: <1f36d45e-3ca9-bfb8-0634-901c42390e2c@users.sourceforge.net> <8594c152-68a4-c0c7-b4c6-49c753b0c748@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v495oNZd017804 On Mon, 8 May 2017 19:42:46 +0200 SF Markus Elfring wrote: > > Which issue do you mean? I dont see any issue you fix here. > > Are the run time characteristics a bit nicer for the function “seq_putc” > in comparison to the function “seq_puts” for printing a single line break here? > > Regards, > Markus I would put this in why bother category. seq_puts is correct and this is only in diagnostic output useful to developer and disabled on most distro kernels