From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools: Support srccode output
Date: Tue, 9 May 2017 11:05:39 +0200 [thread overview]
Message-ID: <20170509090539.GA4031@krava> (raw)
In-Reply-To: <20170508202205.28520-1-andi@firstfloor.org>
On Mon, May 08, 2017 at 01:22:05PM -0700, Andi Kleen wrote:
SNIP
> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> index ebfa5d92358a..790ac730b162 100644
> --- a/tools/perf/util/map.c
> +++ b/tools/perf/util/map.c
> @@ -17,6 +17,7 @@
> #include <linux/string.h>
> #include "srcline.h"
> #include "unwind.h"
> +#include "srccode.h"
>
> static void __maps__insert(struct maps *maps, struct map *map);
>
> @@ -414,6 +415,57 @@ int map__fprintf_srcline(struct map *map, u64 addr, const char *prefix,
> return ret;
> }
>
> +int map__fprintf_srccode(struct map *map, u64 addr,
> + const char *prefix, FILE *fp,
> + struct srccode_state *state)
> +{
what's the 'prefix' for? it's always passed as ""
jirka
next prev parent reply other threads:[~2017-05-09 9:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 20:22 [PATCH] perf, tools: Support srccode output Andi Kleen
2017-05-09 9:05 ` Jiri Olsa [this message]
2017-05-09 9:06 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2018-12-04 0:18 Andi Kleen
2018-12-05 12:28 ` Jiri Olsa
2018-12-05 16:54 ` Arnaldo Carvalho de Melo
2018-12-05 17:05 ` Jiri Olsa
2018-12-05 17:33 ` Andi Kleen
2018-12-05 22:15 ` Arnaldo Carvalho de Melo
2017-05-09 12:06 Andi Kleen
2017-05-09 12:36 ` Jiri Olsa
2017-05-05 23:00 Andi Kleen
2017-05-07 14:45 ` Jiri Olsa
2017-05-07 15:29 ` Andi Kleen
2017-05-07 14:45 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509090539.GA4031@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox