From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753149AbdEIM30 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 9 May 2017 08:29:26 -0400
Received: from mga02.intel.com ([134.134.136.20]:58914 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751210AbdEIM3Z (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 May 2017 08:29:25 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,314,1491289200"; 
   d="scan'208";a="85311277"
Date: Tue, 9 May 2017 05:29:24 -0700
From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>, acme@kernel.org, jolsa@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields
Message-ID: <20170509122924.GI27157@tassilo.jf.intel.com>
References: <20170508162134.6265-1-andi@firstfloor.org>
 <20170509121825.GA9983@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170509121825.GA9983@krava>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> so the -F option for 'type:' does not have default set,
> and it looks like the +- don't make sense there:

hw:+comm is just equivalent to hw:comm

Seems fine to me?

hw:-comm won't do anything, but I guess that's expected.

Don't see any need to change this?

> 
> [jolsa@krava perf]$ ./perf script -F hw:+comm | head -3
>               ex 
>               ex 
>               ex 


-Andi