From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753468AbdEINpH (ORCPT ); Tue, 9 May 2017 09:45:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38582 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbdEINpG (ORCPT ); Tue, 9 May 2017 09:45:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B6B077F7B6 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B6B077F7B6 Date: Tue, 9 May 2017 15:45:03 +0200 From: Jiri Olsa To: Andi Kleen Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields Message-ID: <20170509134503.GD9983@krava> References: <20170508162134.6265-1-andi@firstfloor.org> <20170509121825.GA9983@krava> <20170509122924.GI27157@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170509122924.GI27157@tassilo.jf.intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 09 May 2017 13:45:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09, 2017 at 05:29:24AM -0700, Andi Kleen wrote: > > so the -F option for 'type:' does not have default set, > > and it looks like the +- don't make sense there: > > hw:+comm is just equivalent to hw:comm > > Seems fine to me? > > hw:-comm won't do anything, but I guess that's expected. > > Don't see any need to change this? why did you add it in the first place then? jirka