From: Darren Hart <dvhart@infradead.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: peaq-wmi: Add new peaq-wmi driver
Date: Tue, 9 May 2017 07:32:47 -0700 [thread overview]
Message-ID: <20170509143247.GA12520@fury> (raw)
In-Reply-To: <050e6240-0000-b078-2f41-9f117c1ca903@redhat.com>
On Tue, May 09, 2017 at 08:42:21AM +0200, Hans de Goede wrote:
> On 08-05-17 23:04, Darren Hart wrote:
> > On Mon, May 08, 2017 at 09:56:31PM +0200, Hans de Goede wrote:
> > > + peaq_poll_dev->input->name = "PEAQ WMI hotkeys";
> >
> > Are there additional keys/buttons?
>
> Not through the WMI interface on this model, I decided on the
> "PEAQ WMI hotkeys" name rather then say "PEAQ Dolby button"
> as future proofing (this gets exported to userspace so
> we should not change it in the future) in case this driver
> ends up delivering events for more special buttons on
> PEAQ devices.
>
> As for all the other remarks from both you and Dmitry I agree
> with all of them and I will send a v2 addressing them all.
>
Sounds good, thanks Hans.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2017-05-09 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 19:56 [PATCH] platform/x86: peaq-wmi: Add new peaq-wmi driver Hans de Goede
2017-05-08 21:04 ` Darren Hart
2017-05-08 21:34 ` Dmitry Torokhov
2017-05-09 6:42 ` Hans de Goede
2017-05-09 14:32 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509143247.GA12520@fury \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox