From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754034AbdEIOeF (ORCPT ); Tue, 9 May 2017 10:34:05 -0400 Received: from one.firstfloor.org ([193.170.194.197]:52028 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbdEIOeE (ORCPT ); Tue, 9 May 2017 10:34:04 -0400 Date: Tue, 9 May 2017 07:34:01 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields Message-ID: <20170509143401.GW22592@two.firstfloor.org> References: <20170508162134.6265-1-andi@firstfloor.org> <20170509121825.GA9983@krava> <20170509122924.GI27157@tassilo.jf.intel.com> <20170509134503.GD9983@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170509134503.GD9983@krava> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09, 2017 at 03:45:03PM +0200, Jiri Olsa wrote: > On Tue, May 09, 2017 at 05:29:24AM -0700, Andi Kleen wrote: > > > so the -F option for 'type:' does not have default set, > > > and it looks like the +- don't make sense there: > > > > hw:+comm is just equivalent to hw:comm > > > > Seems fine to me? > > > > hw:-comm won't do anything, but I guess that's expected. > > > > Don't see any need to change this? > > why did you add it in the first place then? You mean the Don't override defaults check in the hw types specified case? I guess it could be removed yes. -Andi