From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756433AbdEIRdS (ORCPT ); Tue, 9 May 2017 13:33:18 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:53404 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbdEIRdQ (ORCPT ); Tue, 9 May 2017 13:33:16 -0400 Date: Tue, 9 May 2017 10:33:12 -0700 From: Guenter Roeck To: Moritz Fischer Cc: kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org, lee.jones@linaro.org, bleung@chromium.org, olof@lixom.net Subject: Re: [PATCH] mfd: cros-ec: Add cros_ec_readmem() helpers for I2C/SPI based ECs Message-ID: <20170509173312.GA29374@roeck-us.net> References: <1494273491-7535-1-git-send-email-mdf@kernel.org> <201705091359.KEwXikan%fengguang.wu@intel.com> <20170509163456.GA5885@tyrael.amer.corp.natinst.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170509163456.GA5885@tyrael.amer.corp.natinst.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09, 2017 at 09:34:56AM -0700, Moritz Fischer wrote: > On Tue, May 09, 2017 at 01:56:14PM +0800, kbuild test robot wrote: > > Hi Moritz, > > > > [auto build test WARNING on ljones-mfd/for-mfd-next] > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > > > url: https://github.com/0day-ci/linux/commits/Moritz-Fischer/mfd-cros-ec-Add-cros_ec_readmem-helpers-for-I2C-SPI-based-ECs/20170509-040606 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next > > config: tile-allmodconfig > > compiler: tilegx-linux-gcc (GCC) 4.6.2 > > reproduce: > > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > make.cross ARCH=tile allmodconfig > > make.cross ARCH=tile > > I just locally ran that and it wouldn't print a warning. False positive? > Good question. This is an unusual report - normally the actual warning ... > > > > All warnings (new ones prefixed by >>): > > ... would be listed here, but is missing. Guenter > > > > vim +279 drivers/mfd/cros_ec.c > > > > 263 return 0; > > 264 } > > 265 EXPORT_SYMBOL(cros_ec_resume); > > 266 > > 267 #endif > > 268 > > 269 int cros_ec_readmem(struct cros_ec_device *ec, unsigned int offset, > > 270 unsigned int bytes, void *dest) > > 271 { > > 272 int ret; > > 273 struct ec_params_read_memmap *params; > > 274 struct cros_ec_command *msg; > > 275 > > 276 if (offset >= EC_MEMMAP_SIZE - bytes) > > 277 return -EINVAL; > > 278 > > > 279 msg = kzalloc(sizeof(*msg) + max(sizeof(*params), bytes), GFP_KERNEL); > > What am I not seeing here? > > 280 if (!msg) > > 281 return -ENOMEM; > > 282 > > 283 msg->version = 0; > > 284 msg->command = EC_CMD_READ_MEMMAP; > > 285 msg->insize = bytes; > > 286 msg->outsize = sizeof(*params); > > 287 > > > > --- > > 0-DAY kernel test infrastructure Open Source Technology Center > > https://lists.01.org/pipermail/kbuild-all Intel Corporation > > Thanks, > > Moritz