From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751435AbdEJFt3 (ORCPT ); Wed, 10 May 2017 01:49:29 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:33399 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbdEJFt1 (ORCPT ); Wed, 10 May 2017 01:49:27 -0400 Date: Wed, 10 May 2017 07:49:22 +0200 From: Ingo Molnar To: "Rafael J. Wysocki" Cc: Kees Cook , linux-kernel@vger.kernel.org, Pavel Machek , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-pm@vger.kernel.org, Daniel Micay Subject: Re: [PATCH] x86/power/64: Use char arrays for asm function names Message-ID: <20170510054922.y6pds2gexwt6fked@gmail.com> References: <20170509210051.GA36504@beast> <4065405.RHJSHBFYFE@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4065405.RHJSHBFYFE@aspire.rjw.lan> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Rafael J. Wysocki wrote: > On Tuesday, May 09, 2017 02:00:51 PM Kees Cook wrote: > > This switches the hibernate_64.S function names into character arrays > > to match other areas of the kernel where this is done (e.g., linker > > scripts). Specifically this fixes a compile-time error noticed by the > > future CONFIG_FORTIFY_SOURCE routines that complained about PAGE_SIZE > > being copied out of the "single byte" core_restore_code variable. > > > > Additionally drops the "acpi_save_state_mem" exern which does not > > appear to be used anywhere else in the kernel. > > > > Cc: Daniel Micay > > Signed-off-by: Kees Cook > > Acked-by: Rafael J. Wysocki > > Or I can queue this up if that's preferred. LGTM too! Acked-by: Ingo Molnar Thanks, Ingo