From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752834AbdEJNLV (ORCPT ); Wed, 10 May 2017 09:11:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58608 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbdEJNLU (ORCPT ); Wed, 10 May 2017 09:11:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BE97C460 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bhe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BE97C460 Date: Wed, 10 May 2017 21:11:15 +0800 From: Baoquan He To: Thomas Gleixner Cc: mingo@kernel.org, keescook@chromium.org, linux-kernel@vger.kernel.org, dyoung@redhat.com, douly.fnst@cn.fujitsu.com, dan.j.williams@intel.com, hpa@zytor.com, x86@kernel.org Subject: Re: [PATCH v4 1/3] KASLR: Parse all memmap entries in cmdline Message-ID: <20170510131115.GH21870@x1> References: <1494309472-5691-1-git-send-email-bhe@redhat.com> <1494309472-5691-2-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 10 May 2017 13:11:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/17 at 02:29pm, Thomas Gleixner wrote: > On Tue, 9 May 2017, Baoquan He wrote: > > > In commit: > > > > f28442497b5c ("x86/boot: Fix KASLR and memmap= collision") > > > > ... the memmap= option is parsed so that KASLR can avoid those reserved > > regions. It uses cmdline_find_option() to get the value if memmap= > > is specified, however the problem is that cmdline_find_option() can only > > find the last entry if multiple memmap entries are provided. This > > is not correct. > > > > In this patch, the whole cmdline will be scanned to search each > > Can you please finally stop using this 'This patch does foo', 'In this > patch' phrases. They are bogus. We already know that this is a patch > otherwise you wouldn't have sent it. > > See Documentation/process/SubmittingPatches.txt > > Aside of that can you please use properly written out words instead of > using random abbreviations in the changelog, e.g. command line instead of > cmdline? > > > memmap, all of them will be parsed and handled. > > A proper example would be: > > Address this by checking each command line token for a "memmap=" match > and parse each instance instead of using cmdline_find_option(). Sorry for those mistakes. Will change accordingly when repost. Thanks Baoquan