From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754364AbdEJQ2y (ORCPT ); Wed, 10 May 2017 12:28:54 -0400 Received: from muru.com ([72.249.23.125]:46882 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754288AbdEJQ2v (ORCPT ); Wed, 10 May 2017 12:28:51 -0400 Date: Wed, 10 May 2017 09:28:47 -0700 From: Tony Lindgren To: Peter Ujfalusi Cc: b-liu@ti.com, gregkh@linuxfoundation.org, vinod.koul@intel.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, balbi@kernel.org, linux-kernel@vger.kernel.org, Russell King , dmaengine@vger.kernel.org, dan.j.williams@intel.com Subject: Re: [PATCH v2 01/10] dmaengine: omap-dma: port_window support correction for both direction Message-ID: <20170510162847.GM3489@atomide.com> References: <20170510084231.19302-1-peter.ujfalusi@ti.com> <20170510084231.19302-2-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170510084231.19302-2-peter.ujfalusi@ti.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Ujfalusi [170510 01:45]: > When the port_window support was verified it was done on setup where only > the MEM_TO_DEV direction was enabled. This got un-noticed and thus only > this direction worked. > > Now that I have managed to get a setup to verify both direction it turned > out that the setup was incorrect: > omap_desc members are settings for the slave port while the omap_sg members > apply to the memory side of the sDMA setup. > > Fixes: 527a27591312 ("dmaengine: omap-dma: Fix the port_window support") > Signed-off-by: Peter Ujfalusi > Cc: Russell King > Cc: dmaengine@vger.kernel.org > Cc: dan.j.williams@intel.com > Cc: vinod.koul@intel.com Tested-by: Tony Lindgren