From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933116AbdEKQbF (ORCPT ); Thu, 11 May 2017 12:31:05 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:36260 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756540AbdEKQbA (ORCPT ); Thu, 11 May 2017 12:31:00 -0400 Date: Thu, 11 May 2017 09:30:56 -0700 From: Stephen Hemminger To: SF Markus Elfring Cc: devel@linuxdriverproject.org, Haiyang Zhang , "K. Y. Srinivasan" , Stephen Hemminger , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 1/4] vmbus: Improve a size determination in vmbus_device_create() Message-ID: <20170511093056.036d93b6@xeon-e3> In-Reply-To: <22c8886f-a38c-23ab-9277-ccccf86b1801@users.sourceforge.net> References: <22c8886f-a38c-23ab-9277-ccccf86b1801@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2017 18:15:46 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 11 May 2017 17:30:10 +0200 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/hv/vmbus_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index 0087b49095eb..6802d74f162c 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -1145,5 +1145,5 @@ struct hv_device *vmbus_device_create(const uuid_le *type, > { > struct hv_device *child_device_obj; > > - child_device_obj = kzalloc(sizeof(struct hv_device), GFP_KERNEL); > + child_device_obj = kzalloc(sizeof(*child_device_obj), GFP_KERNEL); > if (!child_device_obj) { This looks fine. Acked-by: Stephen Hemminger