From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758001AbdEKQmh (ORCPT ); Thu, 11 May 2017 12:42:37 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35238 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757852AbdEKQme (ORCPT ); Thu, 11 May 2017 12:42:34 -0400 Date: Thu, 11 May 2017 09:42:27 -0700 From: Stephen Hemminger To: SF Markus Elfring Cc: devel@linuxdriverproject.org, Haiyang Zhang , "K. Y. Srinivasan" , Stephen Hemminger , kernel-janitors@vger.kernel.org, LKML , Wolfram Sang Subject: Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() Message-ID: <20170511094227.22202648@xeon-e3> In-Reply-To: <2182bf8e-b48a-d3bb-6f26-d4af8c4f1507@users.sourceforge.net> References: <587dbcf5-8b12-fac7-693e-5f471e6d5167@users.sourceforge.net> <20170511093015.4cdfdb6c@xeon-e3> <2182bf8e-b48a-d3bb-6f26-d4af8c4f1507@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2017 18:36:44 +0200 SF Markus Elfring wrote: > > Taking out the message assumes that all callers of this function either log an > > error or pass appropriate error code back to userspace. > > Do you like the default error response by Linux memory allocation functions? The default error message only helps a little. I doubt this will ever fail anyway since only allocated on boot.