From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932909AbdEKOMq (ORCPT ); Thu, 11 May 2017 10:12:46 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:51789 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294AbdEKOMn (ORCPT ); Thu, 11 May 2017 10:12:43 -0400 Date: Thu, 11 May 2017 09:12:35 -0500 From: Bin Liu To: Peter Ujfalusi CC: Joe Perches , , , , , , , Subject: Re: [PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size Message-ID: <20170511141235.GD7154@uda0271908> Mail-Followup-To: Bin Liu , Peter Ujfalusi , Joe Perches , tony@atomide.com, gregkh@linuxfoundation.org, vinod.koul@intel.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, balbi@kernel.org, linux-kernel@vger.kernel.org References: <20170510084231.19302-1-peter.ujfalusi@ti.com> <20170510084231.19302-6-peter.ujfalusi@ti.com> <20170510170754.GA7154@uda0271908> <1494458188.2028.5.camel@perches.com> <2d693d53-ba32-1549-90bd-da92f061cbed@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2d693d53-ba32-1549-90bd-da92f061cbed@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 09:19:17AM +0300, Peter Ujfalusi wrote: > > > On 2017-05-11 02:16, Joe Perches wrote: > >On Wed, 2017-05-10 at 12:07 -0500, Bin Liu wrote: > >>On Wed, May 10, 2017 at 11:42:27AM +0300, Peter Ujfalusi wrote: > >>>We have one register for each EP to set the maximum packet size for both > >>>TX and RX. > >>>If for example an RX programming would happen before the previous TX > >>>transfer finishes we would reset the TX packet side. > >>> > >>>To fix this issue, only modify the TX or RX part of the register. > >[] > >>>diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c > >[] > >>>@@ -389,15 +389,19 @@ static int tusb_omap_dma_program(struct dma_channel *channel, u16 packet_sz, > >>> if (chdat->tx) { > >>> /* Send transfer_packet_sz packets at a time */ > >>>- musb_writel(ep_conf, TUSB_EP_MAX_PACKET_SIZE_OFFSET, > >>>- chdat->transfer_packet_sz); > >>>+ u32 psize = musb_readl(ep_conf, TUSB_EP_MAX_PACKET_SIZE_OFFSET); > >> > >>checkpatch.pl complains about declaration and assignment together. > > > >No it doesn't. > > It 'only' complains about: > WARNING: Missing a blank line after declarations It was it. My bad, I was multi-tasking and didn't read the log carefully. > > which is valid. So will you update the patch to move the declaration to the beginning of the function to avoid this WARNING. I would just fix it locally if you prefer. Regards, -Bin.