From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
CK Hu <ck.hu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Yannick Fertre <yannick.fertre@st.com>,
Philippe Cornu <philippe.cornu@st.com>
Cc: linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>
Subject: [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func.
Date: Thu, 11 May 2017 11:31:27 -0700 [thread overview]
Message-ID: <20170511183128.25085-6-eric@anholt.net> (raw)
In-Reply-To: <20170511183128.25085-1-eric@anholt.net>
drm_encoder_cleanup() finishes with memsetting it to 0, already.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
index 65a3bd7a0c00..4b2cfbd0d43f 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
@@ -83,14 +83,8 @@ static const struct drm_encoder_helper_funcs atmel_hlcdc_panel_encoder_helper_fu
.enable = atmel_hlcdc_rgb_encoder_enable,
};
-static void atmel_hlcdc_rgb_encoder_destroy(struct drm_encoder *encoder)
-{
- drm_encoder_cleanup(encoder);
- memset(encoder, 0, sizeof(*encoder));
-}
-
static const struct drm_encoder_funcs atmel_hlcdc_panel_encoder_funcs = {
- .destroy = atmel_hlcdc_rgb_encoder_destroy,
+ .destroy = drm_encoder_cleanup,
};
static int atmel_hlcdc_panel_get_modes(struct drm_connector *connector)
--
2.11.0
next prev parent reply other threads:[~2017-05-11 18:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 18:31 [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge Eric Anholt
2017-05-11 18:31 ` [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges Eric Anholt
2017-05-12 8:02 ` Boris Brezillon
2017-05-11 18:31 ` [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper Eric Anholt
2017-05-12 8:04 ` Boris Brezillon
2017-05-11 18:31 ` [PATCH v2 4/7] drm/mediatek: Use " Eric Anholt
2017-05-12 8:07 ` Boris Brezillon
2017-05-11 18:31 ` [PATCH v2 5/7] drm/ltdc: " Eric Anholt
2017-05-12 8:17 ` Boris Brezillon
2017-05-30 16:55 ` Philippe CORNU
2017-05-31 6:26 ` Boris Brezillon
2017-05-31 8:01 ` Archit Taneja
2017-05-31 8:07 ` Boris Brezillon
2017-05-31 8:35 ` Archit Taneja
2017-06-01 9:53 ` Philippe CORNU
2017-05-11 18:31 ` Eric Anholt [this message]
2017-05-11 19:15 ` [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func Boris Brezillon
2017-05-11 18:31 ` [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge Eric Anholt
2017-05-11 19:15 ` Boris Brezillon
2017-05-12 7:35 ` Daniel Vetter
2017-06-05 15:36 ` Archit Taneja
2017-06-06 8:57 ` Boris Brezillon
2017-06-06 10:15 ` Archit Taneja
2017-05-12 7:33 ` [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge Boris Brezillon
2017-05-12 10:15 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511183128.25085-6-eric@anholt.net \
--to=eric@anholt.net \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=architt@codeaurora.org \
--cc=boris.brezillon@free-electrons.com \
--cc=ck.hu@mediatek.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=philippe.cornu@st.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox