From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755468AbdEKVXX (ORCPT ); Thu, 11 May 2017 17:23:23 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33806 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755324AbdEKVXV (ORCPT ); Thu, 11 May 2017 17:23:21 -0400 Date: Thu, 11 May 2017 22:23:17 +0100 From: Rui Miguel Silva To: JB Van Puyvelde Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc Message-ID: <20170511212317.GC2085@arch-late.localdomain> References: <20170511205856.27023-1-jbvanpuyvelde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170511205856.27023-1-jbvanpuyvelde@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi JB, Great! thanks for the patch, On Thu, May 11, 2017 at 10:58:56PM +0200, JB Van Puyvelde wrote: >According to checkpatch.pl, kcalloc should be preferred to kzalloc with >multiply. > >Signed-off-by: JB Van Puyvelde Reviewed-by: Rui Miguel Silva Cheers, Rui >--- > drivers/staging/greybus/power_supply.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c >index e85c988b7034..20cac20518d7 100644 >--- a/drivers/staging/greybus/power_supply.c >+++ b/drivers/staging/greybus/power_supply.c >@@ -944,7 +944,7 @@ static int gb_power_supplies_setup(struct gb_power_supplies *supplies) > if (ret < 0) > goto out; > >- supplies->supply = kzalloc(supplies->supplies_count * >+ supplies->supply = kcalloc(supplies->supplies_count, > sizeof(struct gb_power_supply), > GFP_KERNEL); > >-- >2.11.0 >