Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same device

Tony Lindgren
2017-05-12T14:03:29Z

* Nikita Yushchenko <nikita.yoush@cogentembedded.com> [170512 01:22]:
> >> + /*
> >> + * If pctldev is not null, we are claiming hog for it,
> >> + * that means, setting that is served by pctldev by itself.
> >> + *
> >> + * Thus we must skip map that is for this device but is served
> >> + * by other device.
> >> + */
> >> + if (pctldev &&
> >> + strcmp(dev_name(pctldev->dev), map->ctrl_dev_name))
> >> + continue;
> >>
> >> ret = add_setting(p, pctldev, map);
> >> /*
> >> --
> >
> > Maybe add a comment saying pctldev is NULL in the regular case
> > and only exists in the hog case?
>
> Isn't comment above saying exactly that?

Yes it is, you're right :)

Tony