From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756853AbdELFCe (ORCPT ); Fri, 12 May 2017 01:02:34 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43592 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755071AbdELFCc (ORCPT ); Fri, 12 May 2017 01:02:32 -0400 Date: Thu, 11 May 2017 22:02:26 -0700 From: "Paul E. McKenney" To: Jens Axboe Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, tglx@linutronix.de Subject: Re: Lockdep splat involving all_q_mutex Reply-To: paulmck@linux.vnet.ibm.com References: <20170510223407.GA7122@linux.vnet.ibm.com> <10e33da8-316d-9f51-b608-91ff7c68e2fa@kernel.dk> <20170511031354.GB3956@linux.vnet.ibm.com> <0b857dd2-8579-5657-f9c7-3b98645d8f0c@kernel.dk> <20170511202344.GL3956@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170511202344.GL3956@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17051205-0040-0000-0000-0000033A98EA X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007049; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000211; SDB=6.00859350; UDB=6.00425962; IPR=6.00638929; BA=6.00005345; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015421; XFM=3.00000015; UTC=2017-05-12 05:02:29 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17051205-0041-0000-0000-0000072EC273 Message-Id: <20170512050226.GA17718@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-12_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705120097 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 01:23:44PM -0700, Paul E. McKenney wrote: > On Thu, May 11, 2017 at 02:12:39PM -0600, Jens Axboe wrote: > > On 05/10/2017 09:13 PM, Paul E. McKenney wrote: > > > On Wed, May 10, 2017 at 08:55:54PM -0600, Jens Axboe wrote: > > >> On 05/10/2017 04:34 PM, Paul E. McKenney wrote: > > >>> Hello! > > >>> > > >>> I got the lockdep splat shown below during some rcutorture testing (which > > >>> does CPU hotplug operations) on mainline at commit dc9edaab90de ("Merge > > >>> tag 'acpi-extra-4.12-rc1' of git://git.kernel.org/.../rafael/linux-pm"). > > >>> My kneejerk reaction was just to reverse the "mutex_lock(&all_q_mutex);" > > >>> and "get_online_cpus();" in blk_mq_init_allocated_queue(), but then > > >>> I noticed that commit eabe06595d62 ("block/mq: Cure cpu hotplug lock > > >>> inversion") just got done moving these two statements in the other > > >>> direction. > > >> > > >> The problem is that that patch got merged too early, as it only > > >> fixes a lockdep splat with the cpu hotplug rework. Fix is coming Linus' > > >> way, it's in my for-linus tree. > > > > > > Thank you for the update, looking forward to the fix. > > > > It's upstream now. > > Thank you, Jens! I will test it this evening, Pacific Time. And no more lockep splats, thank you! Thanx, Paul