From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757069AbdELJag (ORCPT ); Fri, 12 May 2017 05:30:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51034 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756099AbdELJaS (ORCPT ); Fri, 12 May 2017 05:30:18 -0400 Date: Fri, 12 May 2017 11:30:08 +0200 From: Greg KH To: Matthew Giassa Cc: hdegoede@redhat.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width Message-ID: <20170512093008.GA19482@kroah.com> References: <1494553524-26385-1-git-send-email-matthew@giassa.net> <1494553524-26385-5-git-send-email-matthew@giassa.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494553524-26385-5-git-send-email-matthew@giassa.net> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: > +#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration */ > +#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor Address > + */ > +#define REG_HQ_DESA_8723B 0x0310 /* TX High Queue Descriptor > + * Address > + */ Ick, that looks worse to me now, doesn't it to you? Please leave the original as-is. Also, always test-build your patches :) thanks, greg k-h