From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932653AbdELNy7 (ORCPT ); Fri, 12 May 2017 09:54:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45394 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754530AbdELNy6 (ORCPT ); Fri, 12 May 2017 09:54:58 -0400 Date: Fri, 12 May 2017 15:54:48 +0200 From: Greg KH To: Matthew Giassa Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width Message-ID: <20170512135448.GA17354@kroah.com> References: <1494553524-26385-1-git-send-email-matthew@giassa.net> <1494553524-26385-5-git-send-email-matthew@giassa.net> <20170512093008.GA19482@kroah.com> <20170512125744.qvkafevxzu4x422o@darkstar> <20170512132434.hyqrvayg66zpzrhe@darkstar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170512132434.hyqrvayg66zpzrhe@darkstar> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 12, 2017 at 06:24:34AM -0700, Matthew Giassa wrote: > * Matthew Giassa [2017-05-12 05:57:44 -0700]: > > > * Greg KH [2017-05-12 11:30:08 +0200]: > > > > > On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: > > > > +#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration */ > > > > +#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor Address > > > > + */ > > > > +#define REG_HQ_DESA_8723B 0x0310 /* TX High Queue Descriptor > > > > + * Address > > > > + */ > > > > > > Ick, that looks worse to me now, doesn't it to you? Please leave the > > > original as-is. > > Paring down CC list to reduce noise for off-topic question. > > Quick question: in the trivial case, such as a simple block comment, the > style guide (process/coding-style.rst) proposes this style: > > /* > * Some comments that span over several lines until column limit. > * More comments that span over several lines until column limit. > */ > > Though I see a similar variant often used, which I use by default: > > /* Some comments that span over several lines until column limit. > * More comments that span over several lines until column limit. > */ > > For cases with code plus trailing (lengthy) comment, is it preferred to > let it go past the 80 column limit, or to use one of the following > multi-line styles? ie: > > Type I: > #define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor > * Address */ > > Type II (Ugly): > #define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor > * Address > */ > Neither, best is: /* TX Beacon Descriptor Address */ #define REG_BCNQ_DESA_8723B 0x0308 > Finally, would it be worth proposing the addition of this minor > exception to the style guide? Not really, it's almost too long as it is today. thanks, greg k-h