From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757951AbdELQso (ORCPT ); Fri, 12 May 2017 12:48:44 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:49672 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756679AbdELQsn (ORCPT ); Fri, 12 May 2017 12:48:43 -0400 Date: Fri, 12 May 2017 12:48:36 -0400 From: Johannes Weiner To: Minchan Kim Cc: Huang Ying , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm: swap: move anonymous THP split logic to vmscan Message-ID: <20170512164836.GC22367@cmpxchg.org> References: <87h90sb4jq.fsf@yhuang-dev.intel.com> <1494555684-11982-1-git-send-email-minchan@kernel.org> <1494555684-11982-2-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494555684-11982-2-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 12, 2017 at 11:21:24AM +0900, Minchan Kim wrote: > The add_to_swap aims to allocate swap_space(ie, swap slot and > swapcache) so if it fails due to lack of space in case of THP > or something(hdd swap but tries THP swapout) *caller* rather > than add_to_swap itself should split the THP page and retry it > with base page which is more natural. > > Cc: Johannes Weiner > Signed-off-by: Minchan Kim Acked-by: Johannes Weiner