public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bin Liu <b-liu@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Moreno Bartalucci <moreno.bartalucci@tecnorama.it>,
	Lars Melin <larsm17@gmail.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alessio Igor Bogani <abogani@kernel.org>
Subject: Re: [PATCH] usb-musb: keep VBUS on when device is disconnected
Date: Fri, 12 May 2017 12:40:26 -0500	[thread overview]
Message-ID: <20170512174026.GB651@uda0271908> (raw)
In-Reply-To: <20170512172134.GI3489@atomide.com>

On Fri, May 12, 2017 at 10:21:35AM -0700, Tony Lindgren wrote:
> * Bin Liu <b-liu@ti.com> [170512 08:24]:
> > On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote:
> > > OK. No better ideas except I think we should probably have a separate
> > > timer for keeping VBUS on after state changes eventually.
> > 
> > Currently with the patch below, VBUS is constantly on for host-only
> > mode, and this is what we want. Why we need a separate timer? No one
> > cuts VBUs now for host-only mode.
> 
> Oh I was just thinking what we might want to do in the future if
> we want to cut off VBUS when no devices are connected. If we have

Okay, I see. But I don't think we will ever want to turn off VBUS when
no devices attached for host-only mode. Any other controllers do this?

Turning off VBUS doesn't save us much, because it comes from an external
power rail, and no one consumes it when no devices are attached.

I believe keeping the controller idle as what we have now is sufficient.

Regards,
-Bin.

> a USB modem for example it might first enumerate as some boot device,
> then nothing for 20 seconds while it's booting, and then we have a
> different device enumerating after the modem has booted. During this
> period we want to keep VBUS on and will go through multiple
> OTG_STATE_A_WAIT_BCON states. So we can't really control VBUS using
> the OTG_STATE_WHATEVER alone.
> 
> Regards,
> 
> Tony

  reply	other threads:[~2017-05-12 17:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15 14:08 [PATCH] usb-musb: keep VBUS on when device is disconnected Moreno Bartalucci
2017-03-24 18:58 ` Bin Liu
2017-03-25  7:21   ` Lars Melin
2017-03-27 12:53     ` Moreno Bartalucci
2017-03-27 13:17       ` Bin Liu
2017-03-27 14:30         ` Tony Lindgren
2017-03-27 16:20           ` Moreno Bartalucci
2017-03-27 16:59             ` Tony Lindgren
2017-03-27 17:15               ` Bin Liu
2017-03-27 17:55                 ` Tony Lindgren
2017-05-11 18:50                   ` Bin Liu
2017-05-11 18:55                     ` Tony Lindgren
2017-05-11 19:01                       ` Bin Liu
2017-05-11 19:10                         ` Bin Liu
2017-05-11 19:20                           ` Bin Liu
2017-05-11 19:38                             ` Tony Lindgren
2017-05-11 20:02                               ` Bin Liu
2017-05-11 20:23                                 ` Tony Lindgren
2017-05-11 20:27                                   ` Tony Lindgren
2017-05-11 20:44                                   ` Bin Liu
2017-05-11 21:06                                     ` Tony Lindgren
2017-05-12 13:40                                       ` Bin Liu
2017-05-12 14:58                                         ` Tony Lindgren
2017-05-12 15:21                                           ` Bin Liu
2017-05-12 15:43                                             ` Moreno Bartalucci
2017-05-12 17:21                                             ` Tony Lindgren
2017-05-12 17:40                                               ` Bin Liu [this message]
2017-05-12 17:46                                                 ` Tony Lindgren
2017-05-15  7:07                                             ` Moreno Bartalucci
2017-05-15 12:24                                               ` Bin Liu
2017-03-28  6:10                 ` Moreno Bartalucci
2017-03-28 14:59                   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170512174026.GB651@uda0271908 \
    --to=b-liu@ti.com \
    --cc=abogani@kernel.org \
    --cc=larsm17@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=moreno.bartalucci@tecnorama.it \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox