From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754384AbdEMTTr (ORCPT ); Sat, 13 May 2017 15:19:47 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33328 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752128AbdEMTTp (ORCPT ); Sat, 13 May 2017 15:19:45 -0400 Date: Sat, 13 May 2017 12:19:41 -0700 From: Bjorn Andersson To: John Stultz Cc: lkml , Srinivas Kandagatla , Nicolas Dechesne , Stephen Boyd , Andy Gross , Rob Clark , Vinay Simha , David Brown , Rob Herring Subject: Re: [PATCH 2/2] ARM: dts: nexus7: Add regulator tweaks and wcnss entry to support wifi Message-ID: <20170513191941.GZ15143@minitux> References: <1494623898-27230-1-git-send-email-john.stultz@linaro.org> <1494623898-27230-3-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494623898-27230-3-git-send-email-john.stultz@linaro.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 12 May 14:18 PDT 2017, John Stultz wrote: > lvs7 { > bias-pull-down; > + regulator-always-on; > }; Looking at the downstream regulator definition lvs7 is identified as "pll_vdd" - which I believe is what Qualcomm abbreviates as "px". It's supplied by S4 and as such will provide 1.8V to something. So it's quite likely that I picked the wrong regulator in the dtsi and that this is the px supply of the wcnss. Unfortunately I don't have any 8064 device (with wcnss) hooked up and I can't find any schematics :/ Would you mind changing the riva-pil vddpx-supply to &pm8921_lvs7 and give this a spin? Regards, Bjorn