From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org,
Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Subject: Re: [PATCH v2] serial: exar: Fix stuck MSIs
Date: Sun, 14 May 2017 13:32:22 +0200 [thread overview]
Message-ID: <20170514113222.GA10578@kroah.com> (raw)
In-Reply-To: <ffaa5003-c62a-1bce-eb59-827a762aefb0@siemens.com>
On Sat, May 13, 2017 at 09:09:17AM +0200, Jan Kiszka wrote:
> On 2017-04-24 14:07, Andy Shevchenko wrote:
> > On Mon, 2017-04-24 at 12:30 +0200, Jan Kiszka wrote:
> >> After migrating 8250_exar to MSI in 172c33cb61da, we can get stuck
> >> without further interrupts because of the special wake-up event these
> >> chips send. They are only cleared by reading INT0. As we fail to do so
> >> during startup and shutdown, we can leave the interrupt line asserted,
> >> which is fatal with edge-triggered MSIs.
> >>
> >> Add the required reading of INT0 to startup and shutdown. Also account
> >> for the fact that a pending wake-up interrupt means we have to return
> >> 1
> >> from exar_handle_irq. Drop the unneeded reading of INT1..3 along with
> >> this - those never reset anything.
> >>
> >> An alternative approach would have been disabling the wake-up
> >> interrupt.
> >> Unfortunately, this feature (REGB[17] = 1) is not available on the
> >> XR17D15X.
> >
> > FWIW:
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
>
> Ping. Needs to go into stable 4.11 now as well.
Relax, I'll get to it after 4.12-rc1 is out...
prev parent reply other threads:[~2017-05-14 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 9:36 [PATCH] serial: exar: Fix stuck MSIs Jan Kiszka
2017-04-24 8:59 ` Andy Shevchenko
2017-04-24 9:06 ` Jan Kiszka
2017-04-24 9:45 ` Andy Shevchenko
2017-04-24 10:30 ` [PATCH v2] " Jan Kiszka
2017-04-24 12:07 ` Andy Shevchenko
2017-05-13 7:09 ` Jan Kiszka
2017-05-14 11:32 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170514113222.GA10578@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sudip.mukherjee@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox