From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754153AbdENNIF (ORCPT ); Sun, 14 May 2017 09:08:05 -0400 Received: from mga11.intel.com ([192.55.52.93]:44513 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbdENNID (ORCPT ); Sun, 14 May 2017 09:08:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,340,1491289200"; d="scan'208";a="1168930256" Date: Sun, 14 May 2017 18:40:08 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: b-liu@ti.com, tony@atomide.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, balbi@kernel.org, linux-kernel@vger.kernel.org, Russell King , dmaengine@vger.kernel.org, dan.j.williams@intel.com Subject: Re: [PATCH v3 1/9] dmaengine: omap-dma: port_window support correction for both direction Message-ID: <20170514131008.GL6263@localhost> References: <20170512135752.1800-1-peter.ujfalusi@ti.com> <20170512135752.1800-2-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170512135752.1800-2-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 12, 2017 at 04:57:44PM +0300, Peter Ujfalusi wrote: > When the port_window support was verified it was done on setup where only > the MEM_TO_DEV direction was enabled. This got un-noticed and thus only > this direction worked. > > Now that I have managed to get a setup to verify both direction it turned > out that the setup was incorrect: > omap_desc members are settings for the slave port while the omap_sg members > apply to the memory side of the sDMA setup. Acked-by: Vinod Koul -- ~Vinod