From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752311AbdEOAZl (ORCPT ); Sun, 14 May 2017 20:25:41 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58174 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbdEOAZj (ORCPT ); Sun, 14 May 2017 20:25:39 -0400 Date: Mon, 15 May 2017 02:25:31 +0200 From: Andrew Lunn To: Maciek Fijalkowski Cc: mst@redhat.com, jasonwang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses Message-ID: <20170515002531.GG14058@lunn.ch> References: <20170514175130.18664-1-macfij7@wp.pl> <20170514175130.18664-2-macfij7@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170514175130.18664-2-macfij7@wp.pl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote: > From: Maciej Fijalkowski Hi Maciek Please include some commit message, even if it is just the checkpatch error you are fixing. Please include the subsystem/driver you are patch in the subject line. Also, your subject of Fix ERROR: makes it sound a lot worse than it is. net: virtio: Fix checkpatch error Complex macros should use () Also, you should at least compile test your change. It is clearly wrong, as shown by 0-day. Andrew