From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753234AbdEODAl (ORCPT ); Sun, 14 May 2017 23:00:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54500 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbdEODAk (ORCPT ); Sun, 14 May 2017 23:00:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DE09CC059722 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mst@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DE09CC059722 Date: Mon, 15 May 2017 06:00:38 +0300 From: "Michael S. Tsirkin" To: Maciek Fijalkowski Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Fix ERROR: code indent should use tabs where possible Message-ID: <20170515055845-mutt-send-email-mst@kernel.org> References: <20170514175130.18664-1-macfij7@wp.pl> <20170514175130.18664-3-macfij7@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170514175130.18664-3-macfij7@wp.pl> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 15 May 2017 03:00:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14, 2017 at 07:51:30PM +0200, Maciek Fijalkowski wrote: > From: Maciej Fijalkowski > > Signed-off-by: Maciej Fijalkowski Acked-by: Michael S. Tsirkin But you really want to fix the subject. Make it less verbose drop upper case and add info about module. Something like: virtio_net: coding style fix: use tabs for indent Also, you misspelled Jason's email. > --- > drivers/net/virtio_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 6c8170c..5d71e9f 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2717,7 +2717,7 @@ static __init int virtio_net_driver_init(void) > if (ret) > goto err_dead; > > - ret = register_virtio_driver(&virtio_net_driver); > + ret = register_virtio_driver(&virtio_net_driver); > if (ret) > goto err_virtio; > return 0; > -- > 2.4.11