From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759249AbdEOKOj (ORCPT ); Mon, 15 May 2017 06:14:39 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36772 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755638AbdEOKOh (ORCPT ); Mon, 15 May 2017 06:14:37 -0400 Date: Mon, 15 May 2017 12:14:33 +0200 From: Johan Hovold To: Geliang Tang Cc: Greg Kroah-Hartman , Johan Hovold , Wolfram Sang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: iowarrior: use memdup_user Message-ID: <20170515101433.GG3657@localhost> References: <908fa521decaf3703e172c3734c0d498741f3ddb.1494580404.git.geliangtang@gmail.com> <22d5f8beb9d993abad615edadfbc23c14a0bdb8d.1494579009.git.geliangtang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22d5f8beb9d993abad615edadfbc23c14a0bdb8d.1494579009.git.geliangtang@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 13, 2017 at 11:16:00AM +0800, Geliang Tang wrote: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang Looks good to me: Reviewed-by: Johan Hovold > --- > drivers/usb/misc/iowarrior.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c > index 7756953..816afad 100644 > --- a/drivers/usb/misc/iowarrior.c > +++ b/drivers/usb/misc/iowarrior.c > @@ -368,14 +368,9 @@ static ssize_t iowarrior_write(struct file *file, > case USB_DEVICE_ID_CODEMERCS_IOWPV2: > case USB_DEVICE_ID_CODEMERCS_IOW40: > /* IOW24 and IOW40 use a synchronous call */ > - buf = kmalloc(count, GFP_KERNEL); > - if (!buf) { > - retval = -ENOMEM; > - goto exit; > - } > - if (copy_from_user(buf, user_buffer, count)) { > - retval = -EFAULT; > - kfree(buf); > + buf = memdup_user(user_buffer, count); > + if (IS_ERR(buf)) { > + retval = PTR_ERR(buf); > goto exit; > } > retval = usb_set_report(dev->interface, 2, 0, buf, count);