From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932970AbdEOKUU (ORCPT ); Mon, 15 May 2017 06:20:20 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47337 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932548AbdEOKUT (ORCPT ); Mon, 15 May 2017 06:20:19 -0400 X-ME-Sender: X-Sasl-enc: 8lrvoomh8rEoVGPnzoDqiRRcuotaPV9mhjfxyUbLHeEv 1494843618 Date: Mon, 15 May 2017 12:20:11 +0200 From: Greg KH To: Matej Dujava Cc: Sudip Mukherjee , Teddy Wang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/9] staging: sm750fb: reordering of macro definitions Message-ID: <20170515102011.GA31131@kroah.com> References: <1494715362-5545-1-git-send-email-mdujava@kocurkovo.cz> <1494715362-5545-4-git-send-email-mdujava@kocurkovo.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494715362-5545-4-git-send-email-mdujava@kocurkovo.cz> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14, 2017 at 12:42:36AM +0200, Matej Dujava wrote: > This patch reorder definition of macros so all macros are in same order. > > Signed-off-by: Matej Dujava > --- > drivers/staging/sm750fb/ddk750_display.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h > index 6f639d7..cef7f46 100644 > --- a/drivers/staging/sm750fb/ddk750_display.h > +++ b/drivers/staging/sm750fb/ddk750_display.h > @@ -81,8 +81,8 @@ > #define DPMS_OFFSET 9 > #define DPMS_MASK (3 << DPMS_OFFSET) > #define DPMS_USAGE (DPMS_MASK << 16) > -#define DPMS_OFF ((3 << DPMS_OFFSET) | DPMS_USAGE) > #define DPMS_ON ((0 << DPMS_OFFSET) | DPMS_USAGE) > +#define DPMS_OFF ((3 << DPMS_OFFSET) | DPMS_USAGE) What "order" are you speaking of here? I don't understand why this change is needed, sorry. greg k-h