Re: [patch 11/18] iommu/of: Adjust system_state check

Robin Murphy
2017-05-15T10:45:58Z

On 14/05/17 19:27, Thomas Gleixner wrote:
> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
>
> Adjust the system_state check in of_iommu_driver_present() to handle the
> extra states.

FWIW,

Acked-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: iommu@lists.linux-foundation.org
> ---
> drivers/iommu/of_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/iommu/of_iommu.c
> +++ b/drivers/iommu/of_iommu.c
> @@ -103,7 +103,7 @@ static bool of_iommu_driver_present(stru
> * it never will be. We don't want to defer indefinitely, nor attempt
> * to dereference __iommu_of_table after it's been freed.
> */
> - if (system_state > SYSTEM_BOOTING)
> + if (system_state >= SYSTEM_RUNNING)
> return false;
>
> return of_match_node(&__iommu_of_table, np);
>