From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Kirk Reiser <kirk@reisers.ca>,
speakup@linux-speakup.org, John Covici <covici@ccs.covici.com>,
Chris Brannon <chris@the-brannons.com>
Subject: Re: [patch v2 1/1] staging: speakup: flush tty buffers and ensure hardware flow control
Date: Mon, 15 May 2017 12:45:56 +0200 [thread overview]
Message-ID: <20170515104556.GA32112@kroah.com> (raw)
In-Reply-To: <20170512194358.GA25867@sanghar>
On Fri, May 12, 2017 at 08:43:58PM +0100, Okash Khawaja wrote:
> This patch fixes the issue where TTY-migrated synths would take a while
> to shut up after hitting numpad enter key. When calling synth_flush,
> even though XOFF character is sent as high priority, data buffered in
> TTY layer is still sent to the synth. This patch flushes that buffered
> data when synth_flush is called.
>
> It also tries to ensure that hardware flow control is enabled, by
> setting CRTSCTS using tty's termios.
>
> Reported-by: John Covici <covici@ccs.covici.com>
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Doesn't apply as I didn't take your full series. Please resend it with
that series fixed up.
thanks,
greg k-h
prev parent reply other threads:[~2017-05-15 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 12:40 [patch 0/1] staging: speakup: flush tty buffers and ensure hardware flow control okash.khawaja
2017-05-09 12:40 ` [patch 1/1] " okash.khawaja
2017-05-10 19:41 ` Alan Cox
2017-05-11 8:29 ` Okash Khawaja
2017-05-11 13:33 ` Alan Cox
2017-05-12 19:35 ` Okash Khawaja
2017-05-12 20:18 ` Alan Cox
2017-05-12 19:43 ` [patch v2 " Okash Khawaja
2017-05-15 10:45 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515104556.GA32112@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris@the-brannons.com \
--cc=covici@ccs.covici.com \
--cc=devel@driverdev.osuosl.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=okash.khawaja@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).