From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933841AbdEOLTd (ORCPT <rfc822;w@1wt.eu>);
        Mon, 15 May 2017 07:19:33 -0400
Received: from mga04.intel.com ([192.55.52.120]:12960 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932311AbdEOLTb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 May 2017 07:19:31 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,344,1491289200"; 
   d="scan'208";a="86877749"
Date: Mon, 15 May 2017 14:19:10 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
        Jean Delvare <jdelvare@suse.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Wei Yongjun <weiyongjun1@huawei.com>, bbaude@redhat.com,
        mildred-bug.kernel@mildred.fr, barnacs@justletit.be, lvuksta@gmail.com,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk
 to Intel_Strago systems
Message-ID: <20170515111910.GY2768@lahna.fi.intel.com>
References: <20170515110103.59765-1-mika.westerberg@linux.intel.com>
 <20170515110103.59765-4-mika.westerberg@linux.intel.com>
 <1494846878.6967.58.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1494846878.6967.58.camel@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 15, 2017 at 02:14:38PM +0300, Andy Shevchenko wrote:
> On Mon, 2017-05-15 at 14:01 +0300, Mika Westerberg wrote:
> > It turns out there are quite many Chromebooks out there that have the
> > same keyboard issue than Acer Chromebook. All of them are based on
> > Intel_Strago reference and report their DMI_PRODUCT_FAMILY as
> > "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are
> > exceptions
> > for which we add separate entries).
> > 
> > Instead of adding each machine to the quirk table, we use
> > DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the
> > machines out there currently.
> > 
> > 
> 
> > +		.ident = "Intel_Strago based Chromebooks",
> 
> > +		.ident = "Cyan Chromebook",
> 
> > +		.ident = "Samsung Chromebook 3",
> 
> I would do something like below (though I'm fine with current as well).
> 
> 	.ident = "Intel_Strago based Chromebooks (All models)",
> 	.ident = "Intel_Strago based Chromebooks (Cyan)",
> 	.ident = "Samsung Chromebook 3 (Celes)",

Works for me :)

I will change this in v2 accordinly. Thanks.