From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933104AbdEOM5W (ORCPT ); Mon, 15 May 2017 08:57:22 -0400 Received: from mail-sn1nam01on0063.outbound.protection.outlook.com ([104.47.32.63]:22848 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932935AbdEOM5R (ORCPT ); Mon, 15 May 2017 08:57:17 -0400 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Mon, 15 May 2017 05:57:11 -0700 From: Vadim Lomovtsev To: Lorenzo Pieralisi Cc: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Sergey Temerkhanov , Sinan Kaya , Vadim.Lomovtsev@caviumnetworks.com Subject: Re: [RFC/RFT PATCH 1/3] PCI: Introduce pci_bus_find_numa_node() Message-ID: <20170515125711.GA9700@localhost.localdomain> References: <20170426100619.31758-1-lorenzo.pieralisi@arm.com> <1494593045-19911-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> <20170512155040.GA11377@red-moon> <20170512171846.GA21391@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170512171846.GA21391@localhost.localdomain> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: MWHPR18CA0043.namprd18.prod.outlook.com (10.175.9.157) To CY1PR07MB1557.namprd07.prod.outlook.com (10.161.168.149) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8fcbb94f-d56e-4e67-b862-08d49b91e978 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY1PR07MB1557; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB1557;3:aDkdsj/h+LG7NZRc5Hgw99dLSB8UZu80J9ENa3YUSiz6wSGAaMQdhZUGv1VwfMYpoICHqeerZW5k8Al0F4ovA4hjF4qw689UPGp9uc4mH3JybonOPH6pRj2F6RcxpdQriTUq8kaWHrvPetIew9ydAyRvWAIWJ97tfsTG8fSmgpOMzqqtX1XtbrH0zZUF6pyDgrBZtZJNN9pFrve6v7GnakyC+GpD9UVlkeLWQwfHSnDvtJ8NJfuTd5rdNlZKtZZbEe5lgtOqtA65lMhBwjfJYJ40SsXAQZxaYe9PpbRmk2bYmdoGrgpazohlIZO1AWcUf5DNHWo8VpBU9qnipdYRkA==;25:+zqT3rHNupXpRYyYmMKwDLejY2hLEK3rdBxrzsTyo/H+HlU9xFSruO66IKyG79BDgXLVbKPD3yk2o3z7UIviWcrTGC+cz24MnBNM68YObrvI+E9HUXLVHcqTddliYQZRCJe796prPstBC/uOs8kn8nQpGzP75JGgz0HSKmBu41FsUXYyiFo9uAzhVkRJZ99MJ+Opvip3YTKgD3gfLuoUbjuR2I6/q4QpYJLYhXyUCp2Mvzo0/CzBcvHV9IaiWlKpgm6eesZiJeLqOhj+p2fttjB4vL2GM9l6DOG1U4ivFiXfV8bkkxX7F5YKCk0HBIElnZcfjqSTNUDywd+lZOCSZDNkJcEwQFmPM38Ms8wL2M6u4CBBxIu22mzj5p8qhJRdv188Ij8rkzIEAIO3QTXn/c6ozwcnOyjgoPXUCIPLdeS5pLXUwG2FBBTBZvIr0qqDUkHXITBFvWPx5tKHnOsV9+Y7f6Isd5Nh6JV+NoqKk5k= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB1557;31:kXIrtqIwRks7TpvnYzSXuJZSOnF0lLQrzK55eVKKGebqvugILlG1Lqwc4XvJU5V54S4zZODGsx/Olf8w60b3AWnWMJobByRYzttf3XivBXIBx0E2eSYRxBtR+B06QsxbZX1O9DIZ8W//UOACr0KW2DfTfSRloz3ztcOflD9wUWhDEnN+8PJNmr3AYMAx3dGFuvrfLQo9Rd1ptzr565h9oBxqvE5MWbIKNnJtSr6Nj2c=;20:YKnfATz8CJe5CDYfyXiNUBhlJ29NffgE+KDCCwJL2FrgHmsWpHU7EHmDU8G6JjWIvzCwhPJXeK7iMK6vZRzKSfgC06KM+ErTCZTfh4g+Emms5wOtw172iRAV4zv2T7wznKhSW1xmBLLuVK/Tk7jQZv6cFvEZs4ojKkx9QpzKRrbsLWldsh3vmFGzXXqXg1gqJ+hXC5nfOxKYm8b87rakRReqvcexUtpqVcvIYPI/MOwHb4xslI4qr50Dtulk98vG9Dw3n7Vuxqr6Ce0g10g/0dmK/rOToU5k5UpZM0bRE5D1cODTr6mvR52gCeQ7uyhnhs/ofzOpRgtxak05UFJ7A0MUYAvZ6B4bhd754TADaMrbbVLkP560eL+6lg1MFvA6hlrEcMwCaOA7HJ+4LvjlEl3tASgf39+34Y9JY9X6hcKQMU+4yFEwP3srDf+nV/X+VI2L1L3F75Khqel+4tr4U3kcAGXB0zPfFfg81xab5Wys2LzWnZCXK/EReCb95m1FaTAmHEIaTSL08FTr+vEraXizkEqI4lxCoKx+RZaNJG0Qxh0Rngl1pUn+Q4mzfH5gXPReURlf7GHbSH2b+8RAXkDeC5/hRQI0vrrdcYXu3wM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(6072148);SRVR:CY1PR07MB1557;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB1557; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB1557;4:d39M/IWAZ+wVJb8g/lvMpM5umiKTyogPvjsMOFXZ939uV3OR6WvEDVywvd5+3nVZBALhMPO/VBxmmG7NQA3TPJ6brn/UgnkMC7L42Wd9U9EqFhJeNS2oVURkacI8BroY+o2GY8uHeRwNwwetcCd6ruTJq69lIkOI0ma4lWExtGJt2WqQrl1ryzIJjDrI8BPVMvVcn219O6pujytJffQXRGQC0mDjtGsaJB+Buu5AvvKSRR9Aj8sodsFrAhcCPEeSH6+HZKFGyHxjiApd6N510ylSfFcauOnlCHHI+jnb1cH5Sckx5Qf/JXcOsHYcK8R5T1yJ9rqhUZI9ZFSflAkoyLxMmCkIBppaTvp0H+NUxboDtGlgHIQmDULB2Mu/2v9ZxmfWYswahGBSkbgjiBkIxYwWJZpd9G92BsfvL4zTZ9/Up+tLloA/CP2qHnzylJ6H/aYyPJ0hFeL1xtspVIkruIaAkpv+r8xsxWazB6pJtL+lxanKd12rVH0aKuUV5Fmm3KmxtQSHzxdKRIfyFe88uwVC3JW4Ed3YoRuHgO+EwcoxKH/B5n3b0XzVx+YLWUb5/xcyM6tiVCdUZbl+nXV/G0BVkwWqHMwHbpfSFx6gGxVlsTqlN7MDYmQaXN+45YxeC1ICEyrwPpVyWmfAKu4eojdkQlAobpkyz4szgvfqXxh2vEHBwKhBiqXNg0DekO4RCFXQB9qu23a+zu7HB7+Bu5bh4i/47tC/2VPmSNZGKyzkGZPPbPoDCmbxWdOtemrqeGRpbRIDeY1S7SSE+26oMw== X-Forefront-PRVS: 0308EE423E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39850400002)(39410400002)(39400400002)(39840400002)(39450400003)(24454002)(2906002)(229853002)(23726003)(1076002)(50466002)(33656002)(42882006)(6916009)(2950100002)(478600001)(110136004)(107886003)(189998001)(38730400002)(5660300001)(6246003)(6506006)(83506001)(9686003)(53936002)(72206003)(3846002)(6116002)(4326008)(55016002)(54906002)(54356999)(50986999)(76176999)(61506002)(7736002)(305945005)(4001350100001)(47776003)(81166006)(25786009)(66066001)(6666003)(8676002)(42186005)(93886004)(18370500001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB1557;H:localhost.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB1557;23:FC0Uuctg6HJfaDYchHwudS+j+0LTb79qfXnqSbCs2?= =?us-ascii?Q?mzb/+2Ybsio6DLhmLMTwpV9AtVGgcHxrWpIcCB7C4vmRHImvWgkkRCLzgr3d?= =?us-ascii?Q?cnjjIybOm2rShfx3Zbxc6kkuqnXl0r6hBtdos0+xRJSHk+/FhsZe/xZ5GvxW?= =?us-ascii?Q?MU7kmASXGzLdYlyTQwUtdg26FPmQiMbx5nR4FdOkkwg/cLNitpNUIk7HU578?= =?us-ascii?Q?ji5mdGXTsbj/g0cElMmbCg0dzBE4wE1HMw3m0zdxNyceDanENScigq+Nc/Pa?= =?us-ascii?Q?CRl3YiOKByX8r8vFZZtfdaiOSv9yZiS0xaHYh1XgZ1YuOIF0o9vYB/tt3Zw4?= =?us-ascii?Q?sLBGOdKTRyajArCtG4Xvw4qEPId3t8CBZQ+hcUJFY48mS7B061OXYUn0YzxK?= =?us-ascii?Q?yLvTYqr68tk6QmgPNrdGbVFdGHYwCc/4jnxStYgz36ttbScuVJgiilCRTxcu?= =?us-ascii?Q?lYW5qiow1vYE8kvBNHnTZLT+gPExTlNUPdBjX9bnKlV/a7wPnUHwANH5k+7u?= =?us-ascii?Q?DMN1W/nMj0rkpL/ZhxzJSL2UDzx1580OFgajQF3ZnT8L6ICYYxF0kDrl/9Kz?= =?us-ascii?Q?jNzca4Y0SWXwoYUpyWQkGHEzQNuao8CTKew+aa31bxH5RHc8U/hVhGVe13wN?= =?us-ascii?Q?lYrNxKTsBJ5mzpryTeIyEMz7VuKCYOID/rRutXpaROfrkGA8YOVDED8F0jwB?= =?us-ascii?Q?JMxsQy5Nkto3oRDRKFN7G+AbyR3TfmF3yJFXj7OwHidOTFWsr4gV/uEO5gpI?= =?us-ascii?Q?RBb36MjWwMYJrZtEnnpr1CGmESa81ds8sLNZlke2RzoB2KQKWjPrl0jbyBH9?= =?us-ascii?Q?MNMMx14N3qIpMiOpVTAfM2oR7JofwwSOIwXuygsQ7y2yKznBlsjWl+y4YRMy?= =?us-ascii?Q?qiOmzhkYOZVrTV7VKeWUxpcY+lF94mKj+ibogPHSn5dtTlUWjg2bqKFVTIr4?= =?us-ascii?Q?Ou3fRs6RlE57V8cGU2Relp/D6oowzNPPwiP9sOoGRQ3QwxIxcPrE6pCnJvq7?= =?us-ascii?Q?cMYgdB/xiwhJVJJYwjfkl5v22f1Avosc2a5Ann/pNAUVrdxHZhKVxYMESJ1C?= =?us-ascii?Q?HStYLUgPuEYlwLXsyKuwg3Ei0HBrCJU7L5S9UQHpdZvSCuCndHOhAckCCLn/?= =?us-ascii?Q?mrLRx6fZNORIG9uz5HR04ElVRWZPkEoIJjp7oTiQI9rxSKbg3hTEYsc/ty3d?= =?us-ascii?Q?vxgZO1Z4rkTSijTjXW4rJERnR3OcAOJLoziruUc/70b82NKKDqLZNnBSEifw?= =?us-ascii?Q?Oo1Pmtk0NghyqBqn/tyUb6NAI514lB8xkQowRtr?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB1557;6:xj9XVCshQQinmb9uTHUprhjJFrxeZ3mLo10xCY8A8Od2Wa/EzroiaczaU0NGnHw/DnwyjyDjmul2nid6hR7Wd15Bcp/YeP12OUydCrn6rnhunIUlPu4SutQRvNZ3t8aYrNVU7PUxCl5uy8XmGqzpJtkD0Wd47KH8wWrKbecgNQ9dJTI8LZ5oEUxVGRsk5ak0mvV0DICbknUsMXdHqpq90YAp+VxRMUn4fXp4DlaVFFwVuBbC6Z/V1PshBrhYGq4nn/vSxpbVZS63JJffJXu2QdQcQcp49fcDjBeiuy4/7bJ+fBa9RCrTudcNND06CVjVdcNI/OEEy30nHmvgKPPXLBlCLIOkZMCedmmagPVNwMs7FHn3fp1sxYj9RNxjWIpv1uWZFEC/AmaOWKnssHYXBqLIqBKkd4/txVNO188WXiBFmyfKsM84TzweU/ukxu14UCJSCMNM0JkBg44ENho9rGN1L8tctXWtNPJIiFOIZgXVYFLUTjRvST83eGbkxfxyPVOR8Gx7UpPTUpnVyCoiQQ==;5:dICcD/QfyggUue5k3ayQ0UMvMxmJMx4NPrMLN+h6JE0T+ZzVgK+SMr9P9z9PbrY+lRmXg9ty6dyFgUIBabmSp+tF8yg3Uwx/mCUik1l/VGyyynHuCeoolL/iAyAhTcJeMj7F00XEQdSwlTiEdN7J+g==;24:TkxzRtCLK44XH8nYMxApe8Xr404wnZqdkvsZxZ5KAKyGwsZ8WbIzSAVWF3a9KFjOG5Cqfq80FACVyzX+d2xmCHqZq9e1hMFKR5wfa3QF+yA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB1557;7:bUkG3dEh9JxV4TCj4dyC4GhjkHCEY2DLEZB6/sScSFxXArQkK1qTLnKfv0O2IbjuxPpvsqWuBvALr3ecr2lSWllYKGblZ1GLWZH+XFEs56flaxsFKONqlxmsosJN1FCWV0B0071HNWfGObHky50XDjNV6cHPSqA6vZ6X3zfX1we7xdNh2Hwq3ZxsRGyRYewgPsEnZJf/wa3JmQqw6wMXLnjjcMt+4yQDGAKNbwqz6lv+Xhbp1QZvA220XOhL/5tljGxsT0CLmpY6Jdmv4AZDRWBEM9pUYKJr7SXhQieOlKaWVaW9Y/E5+QH0DdBCWynOaucqc2A3zStfohIsFMUMZg== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2017 12:57:15.0714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB1557 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 12, 2017 at 10:18:46AM -0700, Vadim Lomovtsev wrote: Hi Lorenzo, > Hi Lorenzo > > On Fri, May 12, 2017 at 04:50:40PM +0100, Lorenzo Pieralisi wrote: > > Hi Vadim, > > > > On Fri, May 12, 2017 at 05:44:05AM -0700, Vadim Lomovtsev wrote: > > > Hi Lorenzo, > > > > > > Are there any news related to these patches ? > > > > Not really, I have not received any feedback but I was expecting some > > to make progress here. Have you tested it ? > > > > Please let me know, thanks ! > > Not yet. Plan to test them after weekend and will get back to you. > Here is the results of testing you patches at dual-socketed board with Cavium ThunderX SoC. Each boot kernel boot with acpi=force argument. 1. The 4.12-rc1 couldn't find rootfs partition so can't be tested. 2.1 The 4.11 without your patch set 0 to numa node for pci device cat /sys/bus/pci/devices/*/numa_node got zeroes here for all devices 2.2 The 4.11 with your patches applied set -1 to numa_node for all pci devices same command provides "-1" So looking at your patches.. At the patch 1/3 you implemented pci_bus_find_numa_node function: +int pci_bus_find_numa_node(struct pci_bus *bus) +{ + return NUMA_NO_NODE; +} Then at the 2/3 patch it is called from pci_register_host_bridge: @@ -770,6 +770,7 @@ int pci_register_host_bridge(struct pci_host_bridge *bridge) [..] + set_dev_node(&bus->dev, pci_bus_find_numa_node(bus)); I suppose that is why I'm seeing those -1 in the numa_node field. And at the patch 3/3 you implemented acpi_pci_bus_find_numa_node function +int acpi_pci_bus_find_numa_node(struct pci_bus *bus) which implements actual work of getting numa node value, but it seems that nodoby calls it, isn't it ? Don't we need to update pci_bus_find_numa_node with proper calling of acpi_pci_bus_find_numa_node() ? > > > > Lorenzo > > WBR, > Vadim WBR, Vadim