From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751318AbdEPLlq (ORCPT ); Tue, 16 May 2017 07:41:46 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:59257 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750757AbdEPLlp (ORCPT ); Tue, 16 May 2017 07:41:45 -0400 Date: Tue, 16 May 2017 08:41:37 -0300 From: Mauro Carvalho Chehab To: Peter Zijlstra Cc: Jani Nikula , Darren Hart , linux-kernel@vger.kernel.org, Linux Doc Mailing List , Mauro Carvalho Chehab , Ingo Molnar , Thomas Gleixner Subject: Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST Message-ID: <20170516084137.454925e4@vento.lan> In-Reply-To: <20170516111656.g3uxmcmule2wqlot@hirez.programming.kicks-ass.net> References: <20170512164122.GA17235@fury> <20170512185150.5b48c5f6@vento.lan> <20170512221109.r6yuazrjpikrkg6d@hirez.programming.kicks-ass.net> <20170512221917.GD17235@fury> <20170515070348.htsggm7rgggaqrpd@hirez.programming.kicks-ass.net> <20170515060046.7ba700c7@vento.lan> <20170515093312.eaymomgkcetvpofc@hirez.programming.kicks-ass.net> <874lwmmmzd.fsf@intel.com> <20170515114919.bepernrqonybkmmh@hirez.programming.kicks-ass.net> <20170515142239.00389f0b@vento.lan> <20170516111656.g3uxmcmule2wqlot@hirez.programming.kicks-ass.net> Organization: Samsung X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, 16 May 2017 13:16:56 +0200 Peter Zijlstra escreveu: > On Mon, May 15, 2017 at 02:22:39PM -0300, Mauro Carvalho Chehab wrote: > > Yet, on the other hand, nobody wants lots of warnings/errors > > produced when building the Kernel or the documentation, as it can ride > > important things that would require fixes. > > So would that actually generate a warn/error? Or just generate weird > output? Both warn/error and weird output. From my side, the only reason for writing this patch is to fix the warnings that would otherwise be produced without it: ./kernel/futex.c:492: WARNING: Inline emphasis start-string without end-string. ./kernel/futex.c:1264: WARNING: Block quote ends without a blank line; unexpected unindent. ./kernel/futex.c:1721: WARNING: Block quote ends without a blank line; unexpected unindent. ./kernel/futex.c:2338: WARNING: Block quote ends without a blank line; unexpected unindent. ./kernel/futex.c:2426: WARNING: Block quote ends without a blank line; unexpected unindent. ./kernel/futex.c:2899: WARNING: Block quote ends without a blank line; unexpected unindent. ./kernel/futex.c:2972: WARNING: Block quote ends without a blank line; unexpected unindent. > > Because I'm perfectly fine with weird output. > > Our primary interface to the code is a text editor, and things should be > readable in that form. Anything that detracts from that is a fail. > > If people like to use web browsers (I don't) then I won't stop them, but > they have to realize they're the odd ducks out for viewing things > outside its native form. > > > diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c > > index 198527a62149..858a07590e39 100644 > > --- a/kernel/locking/mutex.c > > +++ b/kernel/locking/mutex.c > > @@ -227,9 +227,9 @@ static void __sched __mutex_lock_slowpath(struct mutex *lock); > > * (or statically defined) before it can be locked. memset()-ing > > * the mutex to 0 is not allowed. > > * > > - * ( The CONFIG_DEBUG_MUTEXES .config option turns on debugging > > - * checks that will enforce the restrictions and will also do > > - * deadlock debugging. ) > > + * (The CONFIG_DEBUG_MUTEXES .config option turns on debugging > > + * checks that will enforce the restrictions and will also do > > + * deadlock debugging) > > * > > * This function is similar to (but not equivalent to) down(). > > */ > > > > > > Thanks, Mauro