From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751710AbdEPMCc (ORCPT ); Tue, 16 May 2017 08:02:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44216 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbdEPMCb (ORCPT ); Tue, 16 May 2017 08:02:31 -0400 Date: Tue, 16 May 2017 14:00:38 +0200 From: Greg Kroah-Hartman To: Okash Khawaja Cc: Jiri Slaby , Samuel Thibault , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Kirk Reiser , speakup@linux-speakup.org, John Covici , Chris Brannon Subject: Re: [patch v2 6/6] staging: speakup: flush tty buffers and ensure hardware flow control Message-ID: <20170516120038.GA5813@kroah.com> References: <20170515174531.968330974@gmail.com> <20170515175627.391877481@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170515175627.391877481@gmail.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote: > This patch fixes the issue where TTY-migrated synths would take a while to shut up after hitting numpad enter key. When calling synth_flush, even though XOFF character is sent as high priority, data buffered in TTY layer is still sent to the synth. This patch flushes that buffered data when synth_flush is called. Minor nit, please line-wrap your changelog text at 72 columns so that I don't have to do it "by hand". > > It also tries to ensure that hardware flow control is enabled, by setting CRTSCTS using tty's termios. > > Reported-by: John Covici > Signed-off-by: Okash Khawaja > Reviewed-by: Samuel Thibault > > Index: linux-staging/drivers/staging/speakup/serialio.c > =================================================================== Are you using git? These lines are odd... thanks, greg k-h