From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753151AbdEPMWf (ORCPT ); Tue, 16 May 2017 08:22:35 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:60281 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751953AbdEPMWc (ORCPT ); Tue, 16 May 2017 08:22:32 -0400 Date: Tue, 16 May 2017 14:22:11 +0200 From: Andrew Lunn To: Jisheng Zhang Cc: adrian.hunter@intel.com, huziji@marvell.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mmc: sdhci-xenon: kill xenon_clean_phy() Message-ID: <20170516122211.GA27959@lunn.ch> References: <20170516061720.1755-1-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170516061720.1755-1-jszhang@marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 16, 2017 at 02:17:20PM +0800, Jisheng Zhang wrote: > Currently, the xenon_clean_phy() is only used for freeing phy_params. > The phy_params is allocated by devm_kzalloc(), there's no need to free > is explicitly. > > Signed-off-by: Jisheng Zhang > --- > drivers/mmc/host/sdhci-xenon-phy.c | 14 +------------- > drivers/mmc/host/sdhci-xenon.c | 6 +----- > drivers/mmc/host/sdhci-xenon.h | 1 - > 3 files changed, 2 insertions(+), 19 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-xenon-phy.c b/drivers/mmc/host/sdhci-xenon-phy.c > index 6356781f1cca..f7e26b031e76 100644 > --- a/drivers/mmc/host/sdhci-xenon-phy.c > +++ b/drivers/mmc/host/sdhci-xenon-phy.c > @@ -787,14 +787,6 @@ int xenon_phy_adj(struct sdhci_host *host, struct mmc_ios *ios) > return ret; > } > > -void xenon_clean_phy(struct sdhci_host *host) > -{ > - struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > - struct xenon_priv *priv = sdhci_pltfm_priv(pltfm_host); > - > - kfree(priv->phy_params); Hi Jisheng If the memory has been allocated using the devm_ API, calling kfree here is wrong, and can lead to a double free. So this patch should probably have a fixes: tag. Should it also goto stable? Andrew