From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbdEPMo2 (ORCPT ); Tue, 16 May 2017 08:44:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60002 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751931AbdEPMoY (ORCPT ); Tue, 16 May 2017 08:44:24 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 08338C04B936 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sgruszka@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 08338C04B936 Date: Tue, 16 May 2017 14:43:41 +0200 From: Stanislaw Gruszka To: Johannes Berg Cc: David Miller , arnd@arndb.de, helmut.schaa@googlemail.com, kvalo@codeaurora.org, daniel@makrotopia.org, dev@kresin.me, pozega.tomislav@gmail.com, vasilugin@yandex.ru, roman@advem.lv, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rt2x00: improve calling conventions for register accessors Message-ID: <20170516124255.GA5440@redhat.com> References: <20170515134711.2770374-1-arnd@arndb.de> <20170515142520.GA13996@redhat.com> <20170515.103951.2305484593464882104.davem@davemloft.net> <20170516115511.GA4230@redhat.com> <1494935936.15923.0.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494935936.15923.0.camel@sipsolutions.net> User-Agent: Mutt/1.5.20 (2009-12-10) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 16 May 2017 12:44:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 16, 2017 at 01:58:56PM +0200, Johannes Berg wrote: > On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote: > > > > In rt2x00 driver we use poor convention in other kind of registers > > accessors like bbp, mac, eeprom. I dislike to changing only rfcsr > > accessors and leaving others in the old way. And changing all > > accessors would be massive and error prone change, which I'm not > > prefer either. > > That's a stupid argument, but for the sake of it - the conversion can > easily be done with coccinelle/spatch without being "error prone". Sure, but still I think it would be preferable to fix newly added rt2800_bw_filter_calibration() function, instead of ancient rfcsr accessors. Stanislaw