From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, andrew@lunn.ch,
jason@lakedaemon.net, jaz@semihalf.com, will.deacon@arm.com,
nadavh@marvell.com, robh+dt@kernel.org, neta@marvell.com,
tn@semihalf.com, gregory.clement@free-electrons.com,
mark.rutland@arm.com, sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description
Date: Tue, 16 May 2017 14:34:46 +0200 [thread overview]
Message-ID: <20170516143446.4a25a306@free-electrons.com> (raw)
In-Reply-To: <1494890913-8360-2-git-send-email-mw@semihalf.com>
Hello,
On Tue, 16 May 2017 01:28:32 +0200, Marcin Wojtas wrote:
> +&cps_eth1 {
> + status = "okay";
> + phy = <&phy0>;
> + phy-mode = "sgmii";
> +};
It would be nice to indicate which connector is that, like is done in
the rest of this Device Tree file.
> +&ap_sdhci0 {
> + status = "okay";
> + bus-width = <8>;
> + no-1-8-v;
> + non-removable;
> +};
> +
> +&cpm_sdhci0 {
> + status = "okay";
> + bus-width = <4>;
> + no-1-8-v;
> + non-removable;
> +};
Same comment. Also, are they both really non-removable? I have a uSD
card connector on my MacchiatoBin board. It isn't covered by those new
entries ?
Also, fix the wording of MacchiatoBin in your commit title/commit log.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-16 12:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 23:28 [PATCH 0/2] Armada 8040 MachiatoBin and DB improvements Marcin Wojtas
2017-05-15 23:28 ` [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description Marcin Wojtas
2017-05-15 23:28 ` Russell King - ARM Linux
2017-05-16 9:27 ` Marcin Wojtas
2017-05-16 9:50 ` Russell King - ARM Linux
2017-05-16 9:55 ` Thomas Petazzoni
2017-05-16 10:02 ` Russell King - ARM Linux
2017-05-16 11:52 ` Thomas Petazzoni
2017-05-16 12:13 ` Russell King - ARM Linux
2017-05-16 12:44 ` Marcin Wojtas
2017-05-16 13:45 ` Russell King - ARM Linux
2017-05-16 11:16 ` Russell King - ARM Linux
2017-05-16 11:33 ` Marcin Wojtas
2017-05-16 11:14 ` Russell King - ARM Linux
2017-05-16 12:34 ` Thomas Petazzoni [this message]
2017-05-16 12:40 ` Russell King - ARM Linux
2017-05-15 23:28 ` [PATCH 2/2] arm64: marvell: dts: add second 1G port on the Armada 8040 DB Marcin Wojtas
2017-05-23 14:24 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516143446.4a25a306@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=neta@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tn@semihalf.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox