From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbdEPMfD (ORCPT ); Tue, 16 May 2017 08:35:03 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:45776 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbdEPMe6 (ORCPT ); Tue, 16 May 2017 08:34:58 -0400 Date: Tue, 16 May 2017 14:34:46 +0200 From: Thomas Petazzoni To: Marcin Wojtas Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andrew@lunn.ch, jason@lakedaemon.net, jaz@semihalf.com, will.deacon@arm.com, nadavh@marvell.com, robh+dt@kernel.org, neta@marvell.com, tn@semihalf.com, gregory.clement@free-electrons.com, mark.rutland@arm.com, sebastian.hesselbarth@gmail.com Subject: Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description Message-ID: <20170516143446.4a25a306@free-electrons.com> In-Reply-To: <1494890913-8360-2-git-send-email-mw@semihalf.com> References: <1494890913-8360-1-git-send-email-mw@semihalf.com> <1494890913-8360-2-git-send-email-mw@semihalf.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, 16 May 2017 01:28:32 +0200, Marcin Wojtas wrote: > +&cps_eth1 { > + status = "okay"; > + phy = <&phy0>; > + phy-mode = "sgmii"; > +}; It would be nice to indicate which connector is that, like is done in the rest of this Device Tree file. > +&ap_sdhci0 { > + status = "okay"; > + bus-width = <8>; > + no-1-8-v; > + non-removable; > +}; > + > +&cpm_sdhci0 { > + status = "okay"; > + bus-width = <4>; > + no-1-8-v; > + non-removable; > +}; Same comment. Also, are they both really non-removable? I have a uSD card connector on my MacchiatoBin board. It isn't covered by those new entries ? Also, fix the wording of MacchiatoBin in your commit title/commit log. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com