Re: [PATCH 3/4] selftests/ftrace: Fix bashisms

Masami Hiramatsu
2017-05-16T14:26:06Z

On Mon, 15 May 2017 11:16:30 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

>
> Masami's the original author of ftracetest.
>
> Masami, are you OK with this change?
>
> -- Steve
>
>
> On Sun, 14 May 2017 01:01:03 +0530
> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
>
> > Fix a few bashisms in ftrace selftests.

Ah, what's a nice fix!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

> >
> > Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> > ---
> > tools/testing/selftests/ftrace/ftracetest | 2 +-
> > tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +-
> > tools/testing/selftests/ftrace/test.d/functions | 4 ++--
> > 3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> > index 32e6211e1c6e..717581145cfc 100755
> > --- a/tools/testing/selftests/ftrace/ftracetest
> > +++ b/tools/testing/selftests/ftrace/ftracetest
> > @@ -58,7 +58,7 @@ parse_opts() { # opts
> > ;;
> > --verbose|-v|-vv)
> > VERBOSE=$((VERBOSE + 1))
> > - [ $1 == '-vv' ] && VERBOSE=$((VERBOSE + 1))
> > + [ $1 = '-vv' ] && VERBOSE=$((VERBOSE + 1))
> > shift 1
> > ;;
> > --debug|-d)
> > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> > index 07bb3e5930b4..aa31368851c9 100644
> > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> > @@ -48,7 +48,7 @@ test_event_enabled() {
> > e=`cat $EVENT_ENABLE`
> > if [ "$e" != $val ]; then
> > echo "Expected $val but found $e"
> > - exit -1
> > + exit 1
> > fi
> > }
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/functions b/tools/testing/selftests/ftrace/test.d/functions
> > index 9aec6fcb7729..f2019b37370d 100644
> > --- a/tools/testing/selftests/ftrace/test.d/functions
> > +++ b/tools/testing/selftests/ftrace/test.d/functions
> > @@ -34,10 +34,10 @@ reset_ftrace_filter() { # reset all triggers in set_ftrace_filter
> > echo > set_ftrace_filter
> > grep -v '^#' set_ftrace_filter | while read t; do
> > tr=`echo $t | cut -d: -f2`
> > - if [ "$tr" == "" ]; then
> > + if [ "$tr" = "" ]; then
> > continue
> > fi
> > - if [ $tr == "enable_event" -o $tr == "disable_event" ]; then
> > + if [ $tr = "enable_event" -o $tr = "disable_event" ]; then
> > tr=`echo $t | cut -d: -f1-4`
> > limit=`echo $t | cut -d: -f5`
> > else
>

--
Masami Hiramatsu