From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753826AbdEQMvu (ORCPT ); Wed, 17 May 2017 08:51:50 -0400 Received: from 8bytes.org ([81.169.241.247]:59650 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbdEQMvr (ORCPT ); Wed, 17 May 2017 08:51:47 -0400 Date: Wed, 17 May 2017 14:51:45 +0200 From: Joerg Roedel To: Arnd Bergmann Cc: Matthias Brugger , Honghui Zhang , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h Message-ID: <20170517125144.GD11068@8bytes.org> References: <20170511113619.2596882-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170511113619.2596882-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 01:35:51PM +0200, Arnd Bergmann wrote: > The mediatek iommu driver relied on an implicit include of dma-mapping.h, > but for some reason that is no longer there in 4.12-rc1: > > drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise': > drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration] > drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free': > drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration] > > This adds an explicit #include to make it build again. > > Signed-off-by: Arnd Bergmann Applied to iommu/fixes, thanks Arnd. This was probably another victim of 208480b iommu: Remove trace-events include from iommu.h