From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753504AbdEQPvm (ORCPT ); Wed, 17 May 2017 11:51:42 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:39001 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbdEQPvi (ORCPT ); Wed, 17 May 2017 11:51:38 -0400 Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=fb.com; Date: Wed, 17 May 2017 16:50:42 +0100 From: Roman Gushchin To: Balbir Singh CC: Johannes Weiner , Tejun Heo , Li Zefan , Michal Hocko , Vladimir Davydov , "cgroups@vger.kernel.org" , "open list:DOCUMENTATION" , "linux-kernel@vger.kernel.org" , linux-mm Subject: Re: [PATCH] mm: per-cgroup memory reclaim stats Message-ID: <20170517155042.GA4133@castle> References: <1494530183-30808-1-git-send-email-guro@fb.com> <1494555922.21563.1.camel@gmail.com> <20170512164206.GA22367@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [2620:10d:c092:200::1:c0bc] X-ClientProxiedBy: DB6PR06CA0004.eurprd06.prod.outlook.com (2603:10a6:6:1::17) To BL2PR15MB1074.namprd15.prod.outlook.com (2603:10b6:201:17::8) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL2PR15MB1074: X-MS-Office365-Filtering-Correlation-Id: f8eb0ac3-e5a0-451b-b031-08d49d3c8482 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:BL2PR15MB1074; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1074;3:3in47hhy2b4wnnMP7f1+Bv6c4lhwkjmc4dTkI1zUvsl/kneewT+By1HJ51Fi8RNIXc2KuH6WEPxYS8aeZF5jwKfCHNOaczXeEpJcd4faipEQDy6t+q9j/LOA5kgTc8kxZfMW3W8Tsand1Ryux5CoJQyio7h0ja8wDj4q2vLhu9AvsdUkU/MaUd1GK3wnlbsiKlGx+lzIQr0A64RlqYSRO5sRzxUUe/GwleUJ++b5pOI5jZaSAGzyqNryjL/misO9NWLaqjXimBIvZPMKlkMONLvaaywBmL7z1xP3zwQ9NggziHcNjN432/NiG++dFnWzAbj+8GgEOUfem/aBQpfgGg==;25:pU965g/BJcOxe9YFrwkcFqXrRNzEHk9VT+a14xhrKtvJKJ37Jh9QdWsO9tWyCDoCkCIlo6X8fJLsMLMdi1RqeZh2TsQum3uuYCJY7+JOqc9/ijWf9POPLrXenHjbJj7sXc2gtn9SAAV94nBiPCRh2Ab7deBHDec4ANxhXwm8PO6LY+/tml3GjMpnEYG+LLleRoqFm6zCNaEB3VCEBnhR5yFfhVpqIaxFe+jptPgu02m7RGOkP1+EappppnwJtLh43nV9APQEDaNQI3MjZLOd8QFDojUFMd5UU4JSCAkzJhXtVF04cls/2cvgr2ls9EBdVHPtlIONKkOEQwzWJRBZekj+sqNWRBLMeOgHaJoeA2R3/w0hyvtKwNwI2MQjP2kAqEPdbYBX2aF0hWWZ/9H9o0i/6jUk/Q34K33bHNASfJKeXXYyUr2bQxVBn9HQkeiUUN+R8hGleLgvUacoN6l2G2JK3QG0zwevMeMkvaLlcME= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1074;31:WRd3LmXbPhsCgR2376Ht/E6RA7Cu1rWAX4V5hSCAYSgREU9AqMCmREwGPmdzzZXw/+aNoQejnWXXNXpBoo9Dw0IUdiftNhQfr83Ar8CjFuoF7oBPbYovfjC1Be4sbl2ordoZNCqwqm1bvene2l54xm3ogEM4isZKsy6uv1CE8sXpNja8nBeExTrp/fcfnb3J6VrhzEgFpHJ+sgR0gHOZOf77fIpXihQz0xaaFgFn8dnPWTGo/B2TKGGo4ih9geg2FZ0l5ZaDYvhXZDjN8zSKbA==;20:1QRpGdnjTrIwZeQoJ3F+qI9dtgDsKfyrRMfWDB83kjQ8SoflMXQfEPfJRR+TdLTCsgEhLuLzj/ivcNmurHAIZgF+ndM+001RmllannVYhBbSVQRt7SFqF7lqjsxJX16qjW1CXWusm+uksM7vP3Zo0zuhUUkrBoAp2i8ZPI36Q+LusFyLGurK5msBVh+zbILE7Dm06eU8qzpXNbAyFp0GnwUH3JVumJ/BafuwYhakmXqMbTRNdRIaNQ5Vm9xXVSICrDbwNtzW/+kpCaagJXMvPJlXgbDvJt+qTtV0d3bXI89lIU5jR97PWiakdPF79wzexZs3eNXwOPhA2diCsQYBET94vr61PpoI0jZV/9femaL7gE5DUW2LyQAGKT2HwQLtM1spFU6U2LhWNZHCOoDaPm4WIhRoEjKNtRsacd+82+p9UJ5Xg6bmcmmNABAv/pzHuQzmcmmRBkC2HThYIMALFHERUFkCx7dpUao9IAhafrSBnB0hSWsYxv4Pzslw3BBy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123555025)(20161123560025)(6072148);SRVR:BL2PR15MB1074;BCL:0;PCL:0;RULEID:;SRVR:BL2PR15MB1074; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1074;4:AY1cWJnuXHc7wXq6hDtMSx+GHgrFkjVKnex0yVur2HQnW2esaLiVXYzHbf7rOs0qUvccmZ7IHLFSQHUL38CW/gL4PtpGAl0BDePB6dCuoZONMZiI76VDznpqTOWmhAHHV2fnYd7XhHLKwsopPssAE38KQtmzBKI62EjpuvLGAhAFBagPBNVYL7dxAj8G76peUaal3iO6VtMjxmuFcq2sqTvM5SAHF4sPm0DYczhEo6Bp2bVcfE1zMy3ejaZXxyvJfFyaVrm08AFLGnQ33VDUqdaM8McC8i5uCm92bl814Qn85qvwLgEQX03/6wS3LVeoyhn4CkI+5gD1Aju2BMtbFbCU7hLSrjwtlHkoZ3DhTI70EVIzvzKv8CXUQEDdBzfPLBKSQ39X+tQedxjNwPS5W7lBp0koxarQTZ9Ty2cg7t6jDhBhx4Ymc5KD/37uKouMoswWngHsrU0qxWt3l5qtFrM9ZSZjkAULRac1aOuElVySzytdE3Cis3/i1AIjmxu0iGLPbTO/ZaZUni5l0zdsKVGCW60zUKlHS8Sj6LiPO7ArfzfIpR+zSUigjA+oMQ9tPjIx0B3R6OTXsjh0jTwo4vx1Na8KNSKPHCCVLFapLj7R4wf7gYidhYQ6MaBDCKGF7i9HQFKItgyrFqdr74s08r7emjgjuV/ozpPeGlRWUuVMy0WgFS8A6wjplAZ3XFjVPHwvBfksPM/scX4gmF6DB0JjQ1EmhVuaINE0hSyicc1BlTtLd3DgkG7UM8juqrwKlM3dvni3hQ74ImQ30u9T6ezovqgyYo0yf0hDTtlyaoJ/+DYBASMW6p68ETlurr4kO2L3nUxj7QaXEnB0TTmfdA== X-Forefront-PRVS: 0310C78181 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39850400002)(39410400002)(39840400002)(39400400002)(39450400003)(24454002)(51444003)(377454003)(54906002)(47776003)(83506001)(55016002)(53936002)(86362001)(478600001)(50986999)(76176999)(9686003)(33656002)(54356999)(7736002)(6496005)(46406003)(305945005)(25786009)(81166006)(53546009)(33716001)(8676002)(50466002)(93886004)(110136004)(6246003)(1411001)(38730400002)(5660300001)(4001350100001)(7416002)(23726003)(42186005)(2906002)(97756001)(189998001)(6916009)(1076002)(2950100002)(229853002)(6666003)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR15MB1074;H:castle;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR15MB1074;23:E1c94770W97Z4Q7PS4SFAEQUh32kWlFE8IH/sMw7V?= =?us-ascii?Q?tby7lmaaCkxnDsTA4TxlxUys+qTnPK1ulGAxXI88mZ9bSlDeAA2A9EiglzTu?= =?us-ascii?Q?4LxWGnlR1BoDw3M1f1T7bSF94uSAAfS9m9DDucCTNyp7fC3rJdqhvq0qzmEt?= =?us-ascii?Q?iMJ7B2MITixv9ksSLO/hlc3WMFM10s+uYnILWLodCHbCHBIRb+7pWDdFBQAV?= =?us-ascii?Q?kMJrKVegf+NiwZ2h/e91wAxm4hGLnRDiuqgKpCvWm7G99/TFrS+KCC3JKzFh?= =?us-ascii?Q?kCM6eOeHGCXVl6AJQ5bnMgTojbEMNL38PFCUtV38odYCsbeewIQA12PJbT9Z?= =?us-ascii?Q?wH9i1Ev4A0dpNkmxpyvqThrM8pe7O6CiKK+qO87cTYiP2TEB7nVSy5jlmUSA?= =?us-ascii?Q?M7vXmq48r56RacyAtEm68XNqmY6F9IRnfd86rjwkXLM3atriICNUO/xfNoI6?= =?us-ascii?Q?yLHp9sUymQOyY4HVyOXFksWAFP10AhduKOgoqLxYPasJK1hVmytlKUqxgMqr?= =?us-ascii?Q?qvQouLR0ihL00PQZaRsQte+5lJ5cpve+CML68NjiHnTyXGrpweeZRgPRuADG?= =?us-ascii?Q?JUsaLY2YCmDBUz3FONoBJ3/DTM7UJh6GDCc/1/j7qkStg89yG4MuT20utDeI?= =?us-ascii?Q?CdaCs0mUvzy3DcsdxqXwBaIif7W52CYVw1vj5ga4ha6+Ln/Ystg/ObRXRFVH?= =?us-ascii?Q?au+gZSKnfL9H0pmKQ9lrNrN7Gz6c2s62i3P/0Goi30+kC2bJfLPZhnLP8tvq?= =?us-ascii?Q?BsY7lvNepprEhqx+Hk0Sw9I9PbnD6b9sl21YXwHO8iqXjjJp9FB4dIVfdCVW?= =?us-ascii?Q?S6kcKHkuflrHgxb+VTi53Jf9YvlLYXypL8aiOgTuVbblj90GZ2ZEy7RzY46Y?= =?us-ascii?Q?qxkRO+p/oNnS2iz72W8wyddvnshfOXeVN6y+lMR0XD/T1Hz+4BO2QjiKpyna?= =?us-ascii?Q?vP2Amduw9pPN15V3lbjBMt+dqN9Of93GDDJbuXhW44L3Fi/4VT1s1Ez/4wv4?= =?us-ascii?Q?u6xqjVCHttdS0HcEI+sBMVtK1mdeDWwMdrv+q2EC1Ci1iIa67F2X/p1+QntK?= =?us-ascii?Q?qVqFbc75byxlvbTRiHK3uyLCCIPHNeshNRhcfIb2gmAZcf6qvuV0RcmxeNvU?= =?us-ascii?Q?DMhsy9W07NVF73i4vMCVWS5NsHDrFzUsC4N0NHf87VYwdpqNgSpcaw2kInxI?= =?us-ascii?Q?iZKBxm6ul1fqMMBp8sRS9UV1Oc+nU5tQStC4cHZTyZS+H+b3J/TNRIV1Yk3r?= =?us-ascii?Q?InQhplWtQie5/kcMSZsN4uYw6SfzMOTMYC7hMfYig/u/SWKOQy1cTBy60z7x?= =?us-ascii?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1074;6:X/tomsHh9oF+CmWckHxPe/2OgeeHBApukDbTl9Xyz32OxsMgvyCk1GYl4t9GVpURnEgvLvvxeo5weskXJmMzptISKuMw0qgZOdZ1Zc2l16zMG9J2pPdGsce/ZkWpXUEWcuuV5J7vL8jDLDe2PS5xVbsDVCGwBcmA7fMCRQqyeAW+fZl2xyA3SYsTxm/Qkh8E7ExZLtgOKo7IfWK8Jy6+8tyLEKsDFQXDRz8RYzmmEI2Mv2ggg4JX85aRfT7K3yeOLaG2u5gXcLyNe43ZstFsnbM5LU/kAO8n74GR/hNRbqOUQFjhrzdxXbQsVQ74GrbQdKyLk2SMydJgorGoP0mrUhT0b7uTRQZaGUpqNj+7ofagsd/KLVUdPpjeDSnyl28WTDVnzBsgamLNmz2mLwakY2LbtqEFuw+JheGxmCo5XL2wx3nKBnudhjeAHhE1Cf2c/MDNuaSYMuyir36X8Sgy71Ya6JoY02FYyNTttTUAL4vBGctFkJhzy3p2uGsuci6eXQqP0n/WRpPzRRoHtTy6lw==;5:ATYVmXDEl7gy+sM7O0AYsF3a05M+1TFtNGes1VYMHfFsVtYFcKGvpD/3Y1WraCPmg7tUxMVwrBIKDIbTt8zHE9KSGEM7ojF1O31SfWDhe7VHCEL8rOqkb18AcVQXAPn+sjOGOeNdEdLhvlDjFy1Lfg==;24:pM7OciPR3ZD5TV2o9DFEtzA4rGECHFNEhTosjp4tfV4E4EUnK8SFK9brpb+ZAIxpYTouAE1EtDgsrF9dAs8yLCmR5Ess2xa9VJ5AoaWq64U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1074;7:kh/q1jVw8JyunhU9g53oZSQ5Rt0oMgVY6S6PLyiiQb0HFIhWXzFEO+ibQ4psCgAiW5uXUGwKO6vTOOV/ODxaf4PXIuvmuTnSjyvKPqh9cl71Q08Cl4B8QlQHoP26qHFsXLXhZJRUnM8YsWZb3KUjO+Fl0Yum/9uepmXLVTrzCUCf/A4SOHu1sWeYEAAHvBmV8q7LOCWrw8Z46/DM2s+xeCrui97/wkgtRotidYgPDqFwIRYenFFYOpDuNWBQreBypyEOLg5CXy5HIKQX0qv3Uy0BhTtXFB2UGHW3TyFV7+xeNayVklwgM00AlV1XMKZr1HngdHzpAWZUdZV8yC46tQ==;20:db5iL6n5oJzp3T0wpTuKN47xJvW2Y4M0KL3pffZwiA+NigO9AbYghBS3SCKd0oCwLF7PF3REx6OY5RRDHPx52do/m6dUan8MP2YbDu1qstL3f3Uz1CMkPDlZSqfelFD0eso1lYijc9P1Y03Zyvd3Zs0Ajtg9sq+8WPRRojNz8hs= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2017 15:50:59.9244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR15MB1074 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-17_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2017 at 08:03:03AM +1000, Balbir Singh wrote: > On Sat, May 13, 2017 at 2:42 AM, Johannes Weiner wrote: > > On Fri, May 12, 2017 at 12:25:22PM +1000, Balbir Singh wrote: > >> > >> It sounds like memcg accumlates both global and memcg reclaim driver > >> counts -- is this what we want? > > > > Yes. > > > > Consider a fully containerized system that is using only memory.low > > and thus exclusively global reclaim to enforce the partitioning, NOT > > artificial limits and limit reclaim. In this case, we still want to > > know how much reclaim activity each group is experiencing. > > But its also confusing to see memcg.stat's value being greater > than the global value? At-least for me. For example PGSTEAL_DIRECT > inside a memcg > global value of PGSTEAL_DIRECT. Do we make > memcg.stat values sum of all impact on memcg or local to memcg? Yes, I think that global counters should include both results of global and per-cgroup reclaim. I will prepare a separate patch for this. Thank you! Roman