From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344AbdEQRW1 (ORCPT ); Wed, 17 May 2017 13:22:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57518 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752823AbdEQRWY (ORCPT ); Wed, 17 May 2017 13:22:24 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 22C0CC057FAF Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mlichvar@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 22C0CC057FAF Date: Wed, 17 May 2017 19:22:20 +0200 From: Miroslav Lichvar To: John Stultz Cc: lkml , Prarit Bhargava , Richard Cochran Subject: Re: [PATCH RFC 0/3] Improve stability of system clock Message-ID: <20170517172220.GB19423@localhost> References: <20170517161317.19557-1-mlichvar@redhat.com> <20170517165756.GA19423@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 17 May 2017 17:22:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2017 at 10:02:00AM -0700, John Stultz wrote: > On Wed, May 17, 2017 at 9:57 AM, Miroslav Lichvar wrote: > > On Wed, May 17, 2017 at 09:30:31AM -0700, John Stultz wrote: > >> Could you submit your linux-tktest infrastructure to the kselftests dir? > > > > I can, but it's a mess that breaks frequently as the timekeeping and > > other kernel code changes. Are you sure you want that in the kernel > > tree? :) > > Being a mess is a slight concern, but as for breaking, if its > in-kernel, then folks can't make changes that break it, right? It duplicates/stubs quite a few kernel functions that are needed to compile and link the timekeeping.c file into an executable. See linux-tktest/missing.c. If their signature changes, or new functions are needed, it will break. Is there a better way to run the timekeeping code in an userspace application? I suspect it would need something like the Linux Kernel Library project. -- Miroslav Lichvar