Re: [PATCH net-next V5 0/9] vhost_net rx batch dequeuing

Michael S. Tsirkin
2017-05-19T16:36:57Z

On Fri, May 19, 2017 at 02:27:16PM +0800, Jason Wang wrote:
>
>
> On 2017年05月18日 04:59, Michael S. Tsirkin wrote:
> > On Wed, May 17, 2017 at 12:14:36PM +0800, Jason Wang wrote:
> > > This series tries to implement rx batching for vhost-net. This is done
> > > by batching the dequeuing from skb_array which was exported by
> > > underlayer socket and pass the sbk back through msg_control to finish
> > > userspace copying. This is also the requirement for more batching
> > > implemention on rx path.
> > >
> > > Tests shows at most 7.56% improvment bon rx pps on top of batch
> > > zeroing and no obvious changes for TCP_STREAM/TCP_RR result.
> > >
> > > Please review.
> > >
> > > Thanks
> > A surprisingly large gain for such as simple change. It would be nice
> > to understand better why this helps - in particular, does the optimal
> > batch size change if ring is bigger or smaller?
>
> Will test, just want to confirm. You mean virtio ring not tx_queue_len here?
>
> Thanks

Exactly.
Thanks,
MST